Fix index out of bounds panic in FfmpegMetadata - #106
Merged
Conversation
Replace direct index access on `self.inputs` with safe alternatives: - `duration()` now uses `.first()` instead of `[0]` - `handle_event` for `ParsedDuration` now uses `.get_mut()` instead of direct indexing Both previously panicked when `inputs` was empty or the index was out of bounds. Closes #105
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105
FfmpegMetadata::duration()panics with "index out of bounds: the len is 0 but the index is 0" whenself.inputsis empty.This replaces direct index access with safe alternatives:
duration()uses.first().and_then(...)instead ofself.inputs[0].durationhandle_eventforParsedDurationuses.get_mut()instead of direct indexingBoth paths previously panicked when inputs were empty or the index was out of bounds.