emit audio progress events - #82
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enables parsing of audio progress events from ffmpeg, which have a different format than video progress events. The key change is making the video-specific fields (frame, fps, and q) optional by defaulting them to 0 when not present, allowing the same parser to handle both audio and video progress messages.
- Modified
try_parse_progressfunction to handle missing video-specific fields - Added test coverage for audio progress parsing
- Updated documentation to clarify behavior for audio-only events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: audio events will have
0for unsupported fields. Fixes #81This is a quick non-breaking fix, supporting parsing audio progress messages which have a slightly different format than video ones:
Video progress:
Audio progress:
Specifically audio progress omits
frame,fps, andqfields.The most thorough and typesafe fix will be to add a dedicated
AudioProgressevent type with those fields omitted. That would be a breaking change in conjunction with adding#[non_exhaustive]to support future added event types.cc @ashhhleyyy fyi