chore: update deps, clippy, and toolchain - #84
Merged
Conversation
...for better diagnostics on assertion fail
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the codebase by updating dependencies and applying Rust clippy lints for cleaner, more idiomatic code. The changes include upgrading from Rust 1.79 to 1.88, updating dependency versions, and applying various clippy suggestions.
- Updated Rust toolchain from 1.79 to 1.88
- Updated dependencies: anyhow (1.0.79 → 1.0.98), ureq (2.10.1 → 3.0.12), tar (0.4.42 → 0.4.44), zip (2.3.0 → 4.3.0), nix (0.29.0 → 0.30.1)
- Applied clippy suggestions to improve code style and performance
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| rust-toolchain | Updated Rust toolchain version from 1.79 to 1.88 |
| Cargo.toml | Updated dependency versions and zip package configuration |
| src/test.rs | Replaced assert! equality checks with assert_eq!, updated format strings and method calls |
| src/read_until_any.rs | Replaced any() iterator with contains() method for better performance |
| src/log_parser.rs | Applied string interpolation, method call improvements, and test assertion updates |
| src/iter.rs | Updated format string to use string interpolation |
| src/download.rs | Updated HTTP response handling for ureq v3, applied string interpolation |
| src/command.rs | Applied string interpolation to format strings |
| examples/*.rs | Applied string interpolation and assert_eq! updates across examples |
Comments suppressed due to low confidence (1)
rust-toolchain:8
- Rust 1.88 does not exist. The latest stable Rust version as of my knowledge cutoff is 1.83. This version should be corrected to an existing stable version.
channel = "1.88" # Avoid specifying a patch version here; see https://github.com/emilk/eframe_template/issues/145
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.