Skip to content

feat: allow skipping ffplay/ffprobe on autodownload - #97

Closed
cnaples79 wants to merge 2 commits into
nathanbabcock:mainfrom
cnaples79:keep-only-ffmpeg
Closed

feat: allow skipping ffplay/ffprobe on autodownload#97
cnaples79 wants to merge 2 commits into
nathanbabcock:mainfrom
cnaples79:keep-only-ffmpeg

Conversation

@cnaples79

@cnaples79 cnaples79 commented Jan 1, 2026

Copy link
Copy Markdown

Summary

  • add env flag to autodownload flows
  • now skips ffplay/ffprobe when the flag is set
  • update examples to pass the new argument

Rationale

  • reduces footprint when only ffmpeg is needed by allowing users to drop ffplay/ffprobe during autodownload

Test Plan

  • compiled locally

Fixes #93

@nathanbabcock nathanbabcock left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cnaples79 thank you and happy New Year!

This will be a great feature to have and I know a few people have been looking for it.

One minor change I'd request: since unpack_ffmpeg is part of the public API, I'd like to keep it backwards-compatible. Adding a third required parameter would cause compile errors for anyone using that function directly after updating.

My preference would be an additional variant, unpack_ffmpeg_without_extras or something like that, so this change is purely additive. That's how we introduced progress events for downloads recently.

Longer term as we collect more of these options perhaps we'd introduce a config struct people could pass rather than env vars. But that would be in a major version bump and in the meantime people could make use of this right away.

@nathanbabcock

Copy link
Copy Markdown
Owner

I believe this is solved in #102. Thank you for getting the ball rolling with this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature request: keep only ffmpeg, ignore ffplay/ffprobe on autodownload

2 participants