fix(deezer): harden metadata parsing against missing API fields#994
Open
berettavexee wants to merge 1 commit into
Open
fix(deezer): harden metadata parsing against missing API fields#994berettavexee wants to merge 1 commit into
berettavexee wants to merge 1 commit into
Conversation
Guard two cases that cause KeyError / IndexError on certain Deezer responses: - resp["contributors"] is absent for some tracks/albums (e.g. singles or compilations served by certain regional APIs). Fall back to .get() with an empty list and use resp["artist"]["name"] / safe_get(resp, "artist", "name") as a secondary fallback so the artist field is never empty. - resp["tracks"][-1] raises IndexError on geo-restricted albums where the track list is empty. Default disctotal to 1 in that case. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two
KeyError/IndexErrorcases in the Deezer metadata parsers cause downloads to fail silently on certain content:1.
resp["contributors"]— KeyErrorAlbumMetadata.from_deezer()andTrackMetadata.from_deezer()accessresp["contributors"]directly. This key is absent for some tracks and albums (singles, compilations, or responses from certain regional API endpoints), raising aKeyErrorthat aborts the download.2.
resp["tracks"][-1]— IndexErrorAlbumMetadata.from_deezer()usesresp["tracks"][-1]["disk_number"]to determinedisctotal. On geo-restricted albums thetrackslist can be empty, causing anIndexError.Fix
Test plan
contributorsin response → artists joined correctlycontributorskey → falls back toresp["artist"]["name"]trackslist →disctotaldefaults to 1, no crash🤖 Generated with Claude Code