(fixes #981) HI_RES_LOSSLESS downloads via MPEG-DASH manifest support#998
Open
joshtheclipper wants to merge 2 commits into
Open
(fixes #981) HI_RES_LOSSLESS downloads via MPEG-DASH manifest support#998joshtheclipper wants to merge 2 commits into
joshtheclipper wants to merge 2 commits into
Conversation
This fork adds support for Tidal's HI_RES_LOSSLESS quality tier, improving the handling of MPEG-DASH manifests and enhancing the download process for hi-res tracks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a issue (#981) where Tidal HI_RES_LOSSLESS tracks would silently fall back to lower quality (HIGH/AAC 320kbps) even on accounts with a HiFi subscription.
Root Cause
Tidal serves HI_RES_LOSSLESS tracks using MPEG-DASH manifests (application/dash+xml) rather than the standard JSON manifest format (application/vnd.tidal.bts) used for lower quality tiers. The existing code in get_downloadable() attempts to json.loads() every manifest and catches JSONDecodeError by falling back to a lower quality — meaning hi-res tracks were never downloaded at hi-res, silently and without a meaningful error.
The warning Failed to get manifest for {track_id}. Retrying with lower quality was the only indication something was wrong.
Changes
streamrip/client/tidal.pyget_downloadable() now checks manifestMimeType on JSONDecodeError and routes application/dash+xml manifests to a new handler instead of falling back
New _get_downloadable_from_dash() method parses the MPEG-DASH XML using xml.etree.ElementTree, extracts the initialization URL, all numbered media segment URLs from the , codec, and sample rate
streamrip/client/downloadable.pyNew TidalDASHDownloadable class inheriting from TidalDownloadable
Downloads initialization segment + all media segments sequentially, concatenating into a temporary .mp4 file
Remuxes from MP4 container to FLAC using ffmpeg -c copy (lossless, no re-encoding) — necessary because Tidal wraps FLAC audio in an MP4/ISOBMFF container even when the codec is FLAC
Fully compatible with existing progress tracking, size reporting, and download pipeline
Requirements
ffmpeg must be installed and available on PATH. This is already a soft dependency of streamrip for other features.
Testing
All HI_RES_LOSSLESS tracks now correctly download as 24-bit FLAC. Tracks that Tidal's API reports as HIGH (AAC) on a per-track basis continue to download correctly as .m4a — this is a Tidal-side licensing limitation and not something that can be addressed client-side.
This fork and pull request were researched, debugged, and written with the assistance of Claude AI (Anthropic). The root cause analysis, code changes, and testing approach were developed collaboratively through an iterative debugging session. The human contributor verified and tested all changes against a live Tidal HiFi account.