Core and Platforms - Updated for latest libnx and fixed compile error#168
Open
EmmmaTech wants to merge 4 commits into
Open
Core and Platforms - Updated for latest libnx and fixed compile error#168EmmmaTech wants to merge 4 commits into
EmmmaTech wants to merge 4 commits into
Conversation
|
(for the record, my PR is for the legacy branch) |
Owner
|
Thanks for the PR! Why change the optional include? I'm not fan of changing
external code like that
Le 11 août 2021 09:53:07 Pablo Curiel ***@***.***> a écrit :
…
(for the record, my PR is for the legacy branch)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
Contributor
Author
|
I think I took it from somewhere else, I'll revert the change and put the optional header on top of the <nanovg/dk_renderer.hpp> header. |
Contributor
Author
|
Actually, that doesn't fix it. If you compile the code, you'll get this error: In file included from /Users/emreterzioglu/Documents/C++_Programs/borealis-fork/working-yoga/./library/lib/extern/nanovg-deko3d/source/dk_renderer.cpp:1:
/Users/emreterzioglu/Documents/C++_Programs/borealis-fork/working-yoga/./library/lib/extern/nanovg-deko3d/include/nanovg/dk_renderer.hpp:168:18:
error: 'optional' in namespace 'std' does not name a template type
168 | std::optional<CMemPool::Handle> m_vertex_buffer;
| ^~~~~~~~This means the optional include has to be moved into the |
Contributor
Author
|
I decided to open an issue in the |
Contributor
Author
|
Alright, so a fix was merged into |
subrepo: subdir: "library/lib/extern/nanovg-deko3d" merged: "5b8661b" upstream: origin: "https://github.com/Adubbz/nanovg-deko3d" branch: "master" commit: "bb69eb5" git-subrepo: version: "0.4.3" origin: "https://github.com/ingydotnet/git-subrepo" commit: "2f68596"
EmmmaTech
changed the title
|
Any plans to merge the fix? Compile error still present and I'm not able to include as a submodule because of it |
Contributor
Author
|
I'm awaiting review from @natinusala |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is identical to #164 except an additional compile error was fixed.