Skip to content

Fix #101 ElementDefinition.id typing is incorrect also on R4B package - #143

Closed
kupsum wants to merge 1 commit into
nazrulworld:mainfrom
kupsum:bug/kupsum/20231101/migrate-issue-101-r4b
Closed

Fix #101 ElementDefinition.id typing is incorrect also on R4B package#143
kupsum wants to merge 1 commit into
nazrulworld:mainfrom
kupsum:bug/kupsum/20231101/migrate-issue-101-r4b

Conversation

@kupsum

@kupsum kupsum commented Nov 1, 2023

Copy link
Copy Markdown

This add fix in #101 also R4B package.

@nazrulworld

nazrulworld commented Nov 2, 2023

Copy link
Copy Markdown
Owner

Hi @kupsum
First of all thanks a lot for your PR. Unfortunately I can't accept this PR for now, because I am little bit confused about the correct Element.id type.
According to FHIR specification, bellow is the definition of the property ´id´

{'id': 'Element.id',
 'isModifier': False,
 'isSummary': False,
 'mapping': [{'identity': 'rim', 'map': 'n/a'}],
 'max': '1',
 'min': 0,
 'path': 'Element.id',
 'representation': ['xmlAttr'],
 'short': 'Unique id for inter-element referencing',
 'type': [{'code': 'http://hl7.org/fhirpath/System.String',
           'extension': [{'url': 'http://hl7.org/fhir/StructureDefinition/structuredefinition-fhir-type',
                          'valueUrl': 'id'}]}]}
 

You can see that an extension 'https://hl7.org/fhir/extensions/StructureDefinition-structuredefinition-fhir-type.html' is used, which clearly indicates that value type should be FHIR primitive type ´id´.

But still you can confirm me about the correct type, I am happy to accept this PR. Happy coding!

NB: it is possible ask relevant question here https://chat.fhir.org

@kupsum

kupsum commented Nov 3, 2023

Copy link
Copy Markdown
Author

Hi @nazruworld!

I'm referencing this document about Element in this PR which states id as string.

Element.id

Definition | Unique id for the element within a resource (for internal references). This may be any string value that does not contain spaces.
Short Display | Unique id for inter-element referencing
Cardinality | 0..1
Type | string

Also, the R5 codebase already has this Element.id specified as fhirtypes.String. See https://github.com/nazrulworld/fhir.resources/blob/main/fhir/resources/element.py#L43

@nazrulworld

Copy link
Copy Markdown
Owner

Hi @nazruworld!

I'm referencing this document about Element in this PR which states id as string.

Element.id

Definition | Unique id for the element within a resource (for internal references). This may be any string value that does not contain spaces. Short Display | Unique id for inter-element referencing Cardinality | 0..1 Type | string

The reference you mentioned, is for R5.

@kupsum

kupsum commented Nov 6, 2023

Copy link
Copy Markdown
Author

Here is link to R4B. The Element.Id is also string in R4B.

@Horstage

Copy link
Copy Markdown

Fixed in main with #160.
To be fixed in 7.X.X with #165.

Sorry, I didn't see this PR before. This PR would be the original and the other two duplicates.

@kupsum kupsum closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants