Skip to content

Move fixtures into conftest - #197

Merged
nazrulworld merged 3 commits into
nazrulworld:mainfrom
mschoettle:mschoettle/move-fixtures
Jan 16, 2026
Merged

Move fixtures into conftest#197
nazrulworld merged 3 commits into
nazrulworld:mainfrom
mschoettle:mschoettle/move-fixtures

Conversation

@mschoettle

@mschoettle mschoettle commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

Fixtures can go directly into conftest.
See: https://docs.pytest.org/en/stable/reference/fixtures.html#conftest-py-sharing-fixtures-across-multiple-files

Follow-up to #193.

When running, at some point, I got an error with the old conftest.py which defined fixtures via pytest_plugins which is why I had changed it to an import.

@mschoettle
mschoettle marked this pull request as draft January 8, 2026 20:08
@mschoettle
mschoettle force-pushed the mschoettle/move-fixtures branch from a642f0f to f9c63c1 Compare January 8, 2026 22:10
@mschoettle
mschoettle marked this pull request as ready for review January 8, 2026 22:11
@mschoettle
mschoettle force-pushed the mschoettle/move-fixtures branch from f9c63c1 to d2026c7 Compare January 9, 2026 02:43
@mschoettle
mschoettle force-pushed the mschoettle/move-fixtures branch from d2026c7 to 97bdb29 Compare January 12, 2026 19:56
@codecov

codecov Bot commented Jan 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (9a2eec1) to head (748143a).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #197      +/-   ##
===========================================
+ Coverage   99.94%   100.00%   +0.05%     
===========================================
  Files         302       300       -2     
  Lines       60040     59990      -50     
===========================================
- Hits        60005     59990      -15     
+ Misses         35         0      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mschoettle

Copy link
Copy Markdown
Contributor Author

@nazrulworld The missing coverage could probably be ignored with # pragma: no cover. And bytes_validator does not seem to be used. What do you think?

@mschoettle
mschoettle marked this pull request as draft January 13, 2026 02:32
@nazrulworld

Copy link
Copy Markdown
Owner

@nazrulworld The missing coverage could probably be ignored with # pragma: no cover. And bytes_validator does not seem to be used. What do you think?

I agree with you, that could be reason.

@mschoettle
mschoettle force-pushed the mschoettle/move-fixtures branch from 5d0b565 to 748143a Compare January 14, 2026 16:43
@mschoettle
mschoettle marked this pull request as ready for review January 14, 2026 18:14
@mschoettle

Copy link
Copy Markdown
Contributor Author

I removed the bytes_validator and marked the corresponding branches of conftest with # pragma: no cover since they either handle errors or are not executed because the FHIR files are cached now and therefore don't have to be downloaded and extracted.

@nazrulworld
nazrulworld merged commit b9a9ffc into nazrulworld:main Jan 16, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants