Skip to content

Fix remote pull ontology process for zipped submissions - #55

Open
syphax-bouazzouni wants to merge 12 commits into
ncbo:developfrom
agroportal:pr/fix-zipped-sumbission-remote-pull
Open

Fix remote pull ontology process for zipped submissions #55
syphax-bouazzouni wants to merge 12 commits into
ncbo:developfrom
agroportal:pr/fix-zipped-sumbission-remote-pull

Conversation

@syphax-bouazzouni

@syphax-bouazzouni syphax-bouazzouni commented May 20, 2022

Copy link
Copy Markdown

Bug fix

The do_remote_ontology_pull that fetches and parses new versions of ontologies if found. Does not work for zipped submissions.

It's because before creating a new submission, it checks if OWLAPI can parse the new file. But this test does not work for ZIP/GZIP files.

related

@syphax-bouazzouni syphax-bouazzouni changed the title Fix remote ontology process not if working if zipped Fix remote pull ontology process for zipped submissions May 20, 2022
@syphax-bouazzouni
syphax-bouazzouni force-pushed the pr/fix-zipped-sumbission-remote-pull branch from eca22b2 to 981bc2a Compare September 21, 2023 02:16
@codecov-commenter

codecov-commenter commented Sep 21, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.38%. Comparing base (ed14911) to head (981bc2a).
⚠️ Report is 274 commits behind head on develop.

Files with missing lines Patch % Lines
lib/ncbo_cron/ontology_pull.rb 50.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #55      +/-   ##
===========================================
+ Coverage    53.95%   54.38%   +0.42%     
===========================================
  Files           15       15              
  Lines         1214     1210       -4     
===========================================
+ Hits           655      658       +3     
+ Misses         559      552       -7     
Flag Coverage Δ
unittests 54.38% <50.00%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants