SVCPLAN-9262: Remove ncsa inventory script

[inwho]

Removes the ncsa_inventory.sh script as well as the related telegraf config file as these have been discontinued by the ICI-monitoring team.

The affected files (/etc/telegraf/scripts/ncsa_inventory.sh and /etc/telegraf/telegraf.d/ncsa_inventory.conf) are not automatically removed on update and will require manual removal if desired (telegraf will continue to execute the check once a week if left alone).

Tested on mgtest02 and mgdb2.

[jakerundall]

Looks fine to me.

re: not having Puppet remove these files, if present — They will presumably stick around a while on stateful nodes, incl. various ISF servers and cluster admin nodes. No concern there?

[inwho]

That is a good point. I was unsure if the tradeoff was worth it, i.e. adding code to specifically check and remove for these two files, because it would quickly become defunct but also be difficult to remove in the future (as this is an external module that has no matching cadence across clusters).

But as I think about it, we will likely migrate this profile into ansible in the near future so maybe that concern isn't as bad as I am imagining it to be.

I think I will add that code to clean up those two files, and add a comment to discard them when rewriting to ansible.

[jakerundall]

Looks good!