-
Notifications
You must be signed in to change notification settings - Fork 24
fix: set CFLAGS to disable bulk-memory for wasm32 C deps #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
r-near
wants to merge
8
commits into
main
Choose a base branch
from
fix/cflags-mcpu-mvp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ec3c408
fix: set CFLAGS/CXXFLAGS to -mcpu=mvp to prevent C deps from emitting…
r-near a2e95fc
fix: scope CFLAGS to wasm32 target only
r-near 22820f3
fix: use targeted -mno-bulk-memory flags instead of -mcpu=mvp
r-near 8c9d136
chore: remove accidentally committed files
r-near c300335
style: rustfmt tuple formatting
r-near 9918a75
fix: migrate integration test templates to edition 2024
r-near ce8df3c
Revert "fix: migrate integration test templates to edition 2024"
r-near fe150d3
Merge branch 'main' into fix/cflags-mcpu-mvp
vsavchyn-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting
CFLAGS/CXXFLAGShere will override any flags the user already has in their shell environment for the entirecargo buildinvocation (not just wasm-target C/C++ compilation). This can break builds that rely on additional CFLAGS or that compile any host-side C code during the build. Consider (a) appending-mcpu=mvpto any existingCFLAGS/CXXFLAGSvalues instead of replacing them, and/or (b) scoping the flags to the wasm32 target only (so host compilation isn’t affected) while still allowing--envto fully override when needed.