Fix tiny int handling#252
Merged
knutwalker merged 3 commits intoAug 12, 2025
Merged
Conversation
madchicken
approved these changes
Aug 3, 2025
madchicken
left a comment
madchicken
left a comment
Collaborator
There was a problem hiding this comment.
The modification makes sense and seems to solve the issue
knutwalker
approved these changes
Aug 12, 2025
knutwalker
left a comment
knutwalker
left a comment
Contributor
There was a problem hiding this comment.
Very good, thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #164 by casting the small i8s to i8 before casting to i64 to avoid the sign being ignored.
coauthor: @robsdedude