Manual update to 2026.04 artifacts#671
Conversation
…ndle semantic errors of "procedure inside query", add formatting of labelComparison to fix tests using comparisonExpression6 (which now does not use LabelExpression). Fix lexersymbols
🦋 Changeset detectedLatest commit: 4f083cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
… into updateArtifacts2026.04
anderson4j
force-pushed
the
updateArtifacts2026.04
branch
from
69d657d to
b2cd21a
Compare
Workaround lintstagedrc/oxfmtrc clash
anderson4j
force-pushed
the
updateArtifacts2026.04
branch
from
b2cd21a to
6c03be3
Compare
| ], | ||
| "vendor/antlr4-c3/index.ts": ["bash check-imports.sh"], | ||
| "*.js": ["oxlint --fix --type-aware --max-warnings 0"], | ||
| "packages/vscode-extension/**/cypher.json": [], |
There was a problem hiding this comment.
had a clash with oxfmtrc for cypher.json. This file called oxfmt on all .json files, but oxfmtrc (rightly, since it's generated) removed cypher.json, causing an "Expected at least one target file"-error.
| @@ -1 +1 @@ | |||
| neo4j-2026.03 | |||
| neo4j-2026.04 | |||
There was a problem hiding this comment.
not forgetting it this time!
| { | ||
| severity: 1, | ||
| message: | ||
| 'Procedure call inside a query does not support naming results implicitly (name explicitly using `YIELD` instead)', |
There was a problem hiding this comment.
Looks like semantic analysis got smart enough to realise the procedure doesnt yield any columns at all, so this error doesnt make sense. Added another test below with a procedure that does have return columns
| ; | ||
|
|
||
| forListClause | ||
| : FOR variable IN expression |
There was a problem hiding this comment.
Think we should add formatter handling for this new clause. Realised that we didnt consider this for a lot of new rules in the past, so thinking maybe I skip it for now and have a look at it all at once later? (this also lets us get in the updated artifacts to upx quicker - before the browser bundling on thursday)
There was a problem hiding this comment.
Made a linear card about it here https://linear.app/neo4j/issue/DEV-534/look-into-formatting-of-new-rules-from-grammar-updates
There was a problem hiding this comment.
PS. I think it can be confusing that I made changes in formatting.ts when I here say I want to fix formatting things later. The change below is more of a fix, since the labelComparison used to have formatting handled by a visitor of it's children, but now that the child-rule changed (it's no longer using labelExpression, which we handle, instead it's a straight up labelExpression4) we need to handle it manually to avoid regression
2 participants
Update grammar and semantic analysis to 2026.04
Fix some tests that changed, and formatting that needed updating
Closes LS-139