Skip to content

feat(pipeline): ADR gate opens a draft PR; PR gate marks it ready#689

Merged
NickSeagull merged 1 commit into
mainfrom
feat/pipeline-draft-pr-flow
Jun 24, 2026
Merged

feat(pipeline): ADR gate opens a draft PR; PR gate marks it ready#689
NickSeagull merged 1 commit into
mainfrom
feat/pipeline-draft-pr-flow

Conversation

@NickSeagull

Copy link
Copy Markdown
Member

What & why

Reworks the feature-pipeline-preview skill so the two maintainer gates produce and finalize a single PR, reviewable on GitHub from the ADR stage onward:

  • ADR gate (phase 3) now commits the ADR, pushes the branch, and opens a draft PR — so the ADR can be reviewed on GitHub (not just on disk) while the pipeline runs. pr_url/pr_number are recorded here.
  • PR gate (phase 16, renamed "Create PR" → "Finalize PR") no longer creates a PR. It commits/pushes the implementation, sets the final conventional-commit title + Jess-facing body (gh pr edit), and flips the draft to ready for review (gh pr ready). It refuses if no phase-3 draft PR exists, so it can never open a second PR.

Changes

  • 03-adr-draft/SKILL.md — adds the commit + push + gh pr create --draft steps; new branch_name/slug inputs; updated Output/Assumptions/Refusals.
  • 16-create-pr/SKILL.md + 16-create-pr/02-submit/SKILL.md — reframed from "create" to "finalize": gh pr edit + gh pr ready against the phase-3 PR instead of gh pr create.
  • SKILL.md (orchestrator) — phase 3/16 descriptions + the PAUSE-gate note.
  • references/phase-allowed-paths.md — phase 3/16 rows.
  • scripts/pipeline.pyPHASES[16] name Create PRFinalize PR (no logic change; cmd_set already accepts pr_url/pr_number).

Notes

  • No pipeline.py behavior change — it already stores pr_url/pr_number via set; only the phase name string changed (py_compile clean).
  • Requires gh and a repo that supports draft PRs (NeoHaskell is public).

🤖 Generated with Claude Code

Rework the feature-pipeline-preview flow so the maintainer reviews on GitHub:

- Phase 3 (ADR draft) now commits the ADR, pushes the branch, and opens a
  DRAFT PR — the maintainer reviews the ADR there instead of only on disk.
  pr_url/pr_number are recorded at this point.
- Phase 16 (renamed "Create PR" -> "Finalize PR") no longer creates a PR; it
  commits/pushes the implementation, sets the final title/body via `gh pr edit`,
  and converts the existing draft PR to ready with `gh pr ready`. Refuses if no
  phase-3 draft PR exists.

Updates the orchestrator SKILL.md (phase 3/16 descriptions + PAUSE-gate note),
the phase-allowed-paths reference, and the PHASES[16] name in pipeline.py.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@NickSeagull, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 12 minutes and 34 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 25fa843a-06d6-49aa-a0db-052128b07985

📥 Commits

Reviewing files that changed from the base of the PR and between 579a44a and 01e2226.

📒 Files selected for processing (6)
  • .claude/skills/feature-pipeline-preview/03-adr-draft/SKILL.md
  • .claude/skills/feature-pipeline-preview/16-create-pr/02-submit/SKILL.md
  • .claude/skills/feature-pipeline-preview/16-create-pr/SKILL.md
  • .claude/skills/feature-pipeline-preview/SKILL.md
  • .claude/skills/feature-pipeline-preview/references/phase-allowed-paths.md
  • .claude/skills/feature-pipeline-preview/scripts/pipeline.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/pipeline-draft-pr-flow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@NickSeagull NickSeagull merged commit fe69837 into main Jun 24, 2026
4 checks passed
@NickSeagull NickSeagull deleted the feat/pipeline-draft-pr-flow branch June 24, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants