WI-2: Unify the three Postgres connection-settings builders (#681)

[NickSeagull]

WI-2: Unify the three Postgres connection-settings builders

This draft PR opens ADR-0062: Single Shared Postgres Connection-Settings Builder for review.

The ADR proposes extracting one shared connection-settings builder (and one shared pool-config builder) in Service.EventStore.Postgres.Core, so all three Postgres pools — EventStore, QueryObjectStore, and FileUpload — route through a single place. Today only EventStore carries the ADR-0037 TCP keepalives, and QueryObjectStore additionally lacks the ADR-0027 pool observation handler; this work item makes keepalives, the observation handler, and the ADR-0060 poolSize apply uniformly, and reserves a single seam for the future sslmode hook (WI-5 / #684). FileUpload keeps sharing PostgresEventStore.poolSize (ADR-0060 Option A) — no independent size.

Scope of this PR right now: the ADR only (Status: Proposed). Implementation (the shared builder, the three pool call-site changes, and the ConnectionSettingsSpec tests) lands in later commits on this branch once the ADR is approved.

This PR stays a draft and is marked Ready for review at the pipeline's PR gate (phase 16), after implementation and review.

Part of the deploy-readiness epic #679 (Phase 2).

Closes #681

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 42d2463f-aec6-4251-a8a7-5ad0f352d1a8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor/681-shared-connection-builder

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}