This repository was archived by the owner on Feb 28, 2024. It is now read-only.
add VRMLImporter - #93
Open
EIA485 wants to merge 7 commits into
Open
Conversation
Member
|
Missing broken on linux flag I imagine since zip contains .exe files which I guess are dependencies. Haven't checked tho yet. Also I'd probs avoid adding the old version and just the new version so that auditing is less work...? |
l-2-j
reviewed
Aug 21, 2022
Comment on lines
+230
to
+236
| "artifacts": [ | ||
| { | ||
| "url": "https://github.com/dfgHiatus/NeosVRMLImporter/releases/download/v1.0.1/VRML_Importer_v1.0.1.zip", | ||
| "filename": "VRML_Importer_v1.0.1.zip", | ||
| "sha256": "727f38e1dfec82ae52867bdbe9b223c33040636adcaf493424860afec4b9c84f" | ||
| } | ||
| ] |
Member
There was a problem hiding this comment.
Agh, anyone else want to review this? I'm too lazy to review anything that the review script is not set up to automatically download, hash check & decompile x'D
Collaborator
|
No comma after the changelog line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mod author is providing a zip as the file, not sure if we should do anything so that down the line an auto installer could install this.