fix(remote-control): prevent duplicate WeChat message processing#469
Merged
fix(remote-control): prevent duplicate WeChat message processing#469
Conversation
Listener accumulation in RemoteControlService caused every inbound WeChat message/callback to be processed twice — doubling session messages, LLM turns, and replies. Root cause: subscribeToAdapter() was called from 4 code paths without removing old listeners when stopAdapter() was skipped (adapter not running). Fixed by folding listener setup into startAdapter() with removeAllListeners() guard, and adding a service-level dedup as defense-in-depth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subscribeToAdapter()added event listeners without removing old ones. WhenstopAdapter()was skipped (adapter not running), listeners accumulated — causing every inbound message/callback to fire twice.subscribeToAdapter()intostartAdapter()withremoveAllListeners()guard. Deleted the separate method and removed all 4 call sites.isDuplicateInbound()dedup helper (2s TTL) guarding bothonMessage()andonCallback()as defense-in-depth.Test plan
bun readypasses (format + typecheck + lint + tests)inbound message:lines/chat,/help,/reposcommands execute only once per invocation