fix(remote-control): fix Telegram adapter race condition#472
Merged
Conversation
…icate bot instances bot.start() is non-blocking but `running` was only set in the onStart callback. This caused testConnection() to report "Adapter is not running" and onConfigChanged() to leak duplicate bot instances on rapid restarts. - Set running=true before bot.start() so isRunning() is immediately accurate - Extract stopBot() helper to stop the bot without removing event listeners - Add stop-guard in start() to prevent leaked instances - Detect polling death via .then() on bot.start() promise - Move setMyCommands to onStart callback to avoid ETIMEDOUT spam - Add testConnection() to adapter interface for real token verification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runningflag was set too late (in grammY'sonStartcallback instead of beforebot.start()), causingtestConnection()to return "Adapter is not running" andonConfigChanged()to leak duplicate bot instances on rapid restartsstopBot()helper that tears down the bot without removing event listeners, preventing the stop-guard from nuking freshly-registered service listenerssetMyCommandstoonStartcallback so it only fires after polling is established, eliminating ETIMEDOUT spam whenapi.telegram.orgis unreachabletestConnection()to the adapter interface, implemented in Telegram viagetMe()for real token/network verificationTest plan
setMyCommandscallstestConnection()returns{ ok: true, botUsername: "..." }immediately after enablingapi.telegram.org→ nosetMyCommandsETIMEDOUT spambun readypasses (typecheck + lint + format + 572 tests)