refactor: replace byteorder crate usage with native rust methods#509
Merged
mohanson merged 1 commit intonervosnetwork:developfrom Apr 9, 2026
Merged
Conversation
…memory operations
Collaborator
Author
|
The CI failure is not an issue with this PR. |
XuJiandong
reviewed
Apr 3, 2026
XuJiandong
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ckb-vm relied on the
byteorderlibrary to handle byte order. However, Rust's standard library (since version 1.44) already provides sufficient functionality to handle byte order, so we can consider removing the byteorder dependency.https://doc.rust-lang.org/std/primitive.u32.html#method.from_le_bytes
Meanwhile, the byteorder repository appears to be no longer maintained, furthermore, the author no longer recommends its use: https://github.com/BurntSushi/byteorder?tab=readme-ov-file#alternatives
I believe we didn't choose byteorder over the Rust standard library, but simply because the ckb-vm repository was created before Rust 1.44