Properly measure mamba's own coverage#72
Open
angelsanzn wants to merge 1 commit intonestorsalceda:masterfrom
Open
Properly measure mamba's own coverage#72angelsanzn wants to merge 1 commit intonestorsalceda:masterfrom
angelsanzn wants to merge 1 commit intonestorsalceda:masterfrom
Conversation
Using mamba's built-in support for coverage to compute mamba's own coverage doesn't provide correct statistics, because by the time the CodeCoverageRunner is set up, half the mamba code has already run. This runs mamba using the `coverage run` command-line tool, which allows `coverage` to hook in early in the import system and hence provide a correct measurement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using mamba's built-in support for coverage to compute mamba's own coverage
doesn't provide correct statistics, because by the time the CodeCoverageRunner
is set up, half the mamba code has already run.
This runs mamba using the
coverage runcommand-line tool, which allowscoverageto hook in early in the import system and hence provide a correctmeasurement.