Fix msd without child - #469
Merged
Merged
Conversation
mtarking
requested changes
Jul 12, 2025
| MD_Extended.vxlan.fabric.type == 'MSD' | ||
| (MD_Extended.vxlan.fabric.type == 'ISN' and | ||
| MD_Extended.vxlan.topology.switches is defined and | ||
| MD_Extended.vxlan.topology.switches | length > 0) |
Collaborator
There was a problem hiding this comment.
For MSD, isn't there a case where topology.switches won't exist in the host_vars as that's managed by child fabric vs MSD?
Collaborator
Author
There was a problem hiding this comment.
I just update the existing, but I agree not sure we need this related to ISN in MSD.
Before:
when: >
(MD_Extended.vxlan.fabric.type == 'ISN' and (MD_Extended.vxlan.topology.switches is defined and MD_Extended.vxlan.topology.switches | length > 0)) or
MD_Extended.vxlan.fabric.type == 'MSD'
Update:
when: >
(MD_Extended.vxlan.fabric.type == 'ISN' and
MD_Extended.vxlan.topology.switches is defined and
MD_Extended.vxlan.topology.switches | length > 0)
or
(MD_Extended.vxlan.fabric.type == 'MSD' and
MD_Extended.vxlan.topology.child_fabrics is defined and
MD_Extended.vxlan.topology.child_fabrics | length > 0)
Expected:
when: >
(MD_Extended.vxlan.fabric.type == 'MSD' and
MD_Extended.vxlan.topology.child_fabrics is defined and
MD_Extended.vxlan.topology.child_fabrics | length > 0)
mtarking
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Fix #468
Related Collection Role
Related Data Model Element
Proposed Changes
Add condition to skip deploy, when there are not switches or child_fabrics. Same for remove role with Network and VRF
dcnm_network and dcnm_vrf, cannot query.
msg": "Fabric
fabricmissing on DCNM or does not have any switches",Test Notes
Cisco NDFC Version
Checklist