Skip to content

Fix msd without child - #469

Merged
mtarking merged 7 commits into
netascode:developfrom
ccoueffe:fix-msd-without_child
Jul 15, 2025
Merged

Fix msd without child#469
mtarking merged 7 commits into
netascode:developfrom
ccoueffe:fix-msd-without_child

Conversation

@ccoueffe

Copy link
Copy Markdown
Collaborator

Related Issue(s)

Fix #468

Related Collection Role

  • cisco.nac_dc_vxlan.validate
  • cisco.nac_dc_vxlan.dtc.create
  • cisco.nac_dc_vxlan.dtc.deploy
  • cisco.nac_dc_vxlan.dtc.remove
  • other

Related Data Model Element

  • vxlan.fabric
  • vxlan.global
  • vxlan.topology
  • vxlan.underlay
  • vxlan.overlay
  • vxlan.overlay_extensions
  • vxlan.policy
  • vxlan.multisite
  • defaults.vxlan
  • other

Proposed Changes

Add condition to skip deploy, when there are not switches or child_fabrics. Same for remove role with Network and VRF

dcnm_network and dcnm_vrf, cannot query.

msg": "Fabric fabric missing on DCNM or does not have any switches",

Test Notes

Cisco NDFC Version

Checklist

  • Latest commit is rebased from develop with merge conflicts resolved
  • New or updates to documentation has been made accordingly
  • Assigned the proper reviewers

@ccoueffe ccoueffe self-assigned this Jul 11, 2025
@ccoueffe ccoueffe added the 0.5.0 Release 0.5.0 label Jul 11, 2025
@ccoueffe
ccoueffe marked this pull request as ready for review July 11, 2025 17:38
@ccoueffe
ccoueffe requested a review from a team as a code owner July 11, 2025 17:38
@ccoueffe ccoueffe added the ready for review PR Ready for Review label Jul 11, 2025
@ccoueffe
ccoueffe requested a review from mtarking July 11, 2025 17:39
Comment thread roles/dtc/remove/tasks/msd/vrfs.yml Outdated
Comment thread roles/dtc/remove/tasks/msd/networks.yml Outdated
Comment thread roles/dtc/deploy/tasks/sub_main_msd.yml Outdated
MD_Extended.vxlan.fabric.type == 'MSD'
(MD_Extended.vxlan.fabric.type == 'ISN' and
MD_Extended.vxlan.topology.switches is defined and
MD_Extended.vxlan.topology.switches | length > 0)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For MSD, isn't there a case where topology.switches won't exist in the host_vars as that's managed by child fabric vs MSD?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just update the existing, but I agree not sure we need this related to ISN in MSD.

Before:

when: >
    (MD_Extended.vxlan.fabric.type == 'ISN' and (MD_Extended.vxlan.topology.switches is defined and MD_Extended.vxlan.topology.switches | length > 0)) or
    MD_Extended.vxlan.fabric.type == 'MSD'

Update:

 when: >
      (MD_Extended.vxlan.fabric.type == 'ISN' and
       MD_Extended.vxlan.topology.switches is defined and
       MD_Extended.vxlan.topology.switches | length > 0)
      or
      (MD_Extended.vxlan.fabric.type == 'MSD' and
       MD_Extended.vxlan.topology.child_fabrics is defined and
       MD_Extended.vxlan.topology.child_fabrics | length > 0)

Expected:

 when: >
      (MD_Extended.vxlan.fabric.type == 'MSD' and
       MD_Extended.vxlan.topology.child_fabrics is defined and
       MD_Extended.vxlan.topology.child_fabrics | length > 0)

@mtarking
mtarking merged commit 8097fed into netascode:develop Jul 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.5.0 Release 0.5.0 ready for review PR Ready for Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not able to initialise an MSD fabric without child fabric

2 participants