Skip to content

Fix support boundary for security to be 12.2.2 or higher - #474

Merged
mtarking merged 4 commits into
developfrom
issue-315
Jul 23, 2025
Merged

Fix support boundary for security to be 12.2.2 or higher#474
mtarking merged 4 commits into
developfrom
issue-315

Conversation

@mtarking

Copy link
Copy Markdown
Collaborator

Related Issue(s)

Resolves #315

Related Collection Role

  • cisco.nac_dc_vxlan.validate
  • cisco.nac_dc_vxlan.dtc.create
  • cisco.nac_dc_vxlan.dtc.deploy
  • cisco.nac_dc_vxlan.dtc.remove
  • other

Related Data Model Element

  • vxlan.fabric
  • vxlan.global
  • vxlan.topology
  • vxlan.underlay
  • vxlan.overlay
  • vxlan.overlay_extensions
  • vxlan.policy
  • vxlan.multisite
  • defaults.vxlan
  • other

Proposed Changes

We needed to actually adjust support for 12.2.2 onward for security.

Test Notes

Cisco NDFC Version

12.2.1
12.2.2

Checklist

  • Latest commit is rebased from develop with merge conflicts resolved
  • New or updates to documentation has been made accordingly
  • Assigned the proper reviewers

@mtarking
mtarking requested review from ccoueffe and mikewiebe July 12, 2025 11:13
@mtarking mtarking self-assigned this Jul 12, 2025
@mtarking mtarking added the ready for review PR Ready for Review label Jul 12, 2025
@mtarking
mtarking requested a review from a team as a code owner July 12, 2025 11:13

@ccoueffe ccoueffe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juburnet
juburnet requested a review from devegupt July 23, 2025 14:08
@mtarking
mtarking merged commit 61920ae into develop Jul 23, 2025
8 checks passed
@mtarking
mtarking deleted the issue-315 branch July 23, 2025 16:20
skaszlik added a commit that referenced this pull request Jul 24, 2025
Updating ebgp_vxlan_support branch

* Fix support boundary for security to be 12.2.2 or higher (#474)
* fix support boundary for security to be 12.2.2 or higher
* update in base
* update in base
* Update msd_fabric_general.j2 (#498)
* Update msd_fabric_general.j2
* Update msd_fabric_resources.j2

* update defaults for breakout interface and nxapi and bootstrap defaults and isn fabric jinja template (#496)

* update defaults for breakout and nxapi

* updates multisite isn bootstrap and nxapi defaults

---------

Co-authored-by: Matt Tarkington <mtarking@cisco.com>
Co-authored-by: juburnet <145139118+juburnet@users.noreply.github.com>
mtarking added a commit that referenced this pull request Sep 9, 2025
* Vxlan ebgp day0. First PR  (#489)

* move initial ebgp fabric work to new branch

* remove tmp file

* Update ebgp_vxlan_fabric_base.j2

* swap fabric global name from standup meeting discussion

* update defaults key

* adjustments from testing with module updates

* update after testing module

* add backwards compatability for 3.1.1

* fix security support

* update security

* backout tasks

* Fabric type "eBGP_VXLAN" added.

* Repo Sync

* Fix for issue with Same-Tier-AS option

* Removing the rule files

* Update ebgp_vxlan_fabric_evpn.j2

To get alligngth with develop branch

* Update nac_dc_validate.py

* Update nac_dc_validate.py

* Update data_model_keys.py

* Update data_model_keys.py

* Update main.yml

* Rename sub_main_bgp.yml to sub_main_ebgp_vxlan.yml

* Update main.yml

* Rename sub_main_bgp.yml to sub_main_ebgp_vxlan.yml

* Update main.yml

* Delete roles/dtc/common/tasks/sub_main_bgp.yml

* Update defaults.yml

* day0 fix - to be able to create a fabric

* Var in upercase, changed to lowercase

---------

Co-authored-by: Matt Tarkington <mtarking@cisco.com>

* Fix for "Multi-AS" option. (#493)

* test

* test removed

* spine_bgp_asn is actually "nvPairs.BGP_AS" so we can reuse existing vxlan.global.bgp_asn

* Fix for "Multi-AS" option. The SUPER_SPINE_BGP_AS and BGP_AS_MODE where under wrong IF statement

* Updating 'ebgp_vxlan_support' branch to be in sync with 'develop' (#502)

Updating ebgp_vxlan_support branch

* Fix support boundary for security to be 12.2.2 or higher (#474)
* fix support boundary for security to be 12.2.2 or higher
* update in base
* update in base
* Update msd_fabric_general.j2 (#498)
* Update msd_fabric_general.j2
* Update msd_fabric_resources.j2

* update defaults for breakout interface and nxapi and bootstrap defaults and isn fabric jinja template (#496)

* update defaults for breakout and nxapi

* updates multisite isn bootstrap and nxapi defaults

---------

Co-authored-by: Matt Tarkington <mtarking@cisco.com>
Co-authored-by: juburnet <145139118+juburnet@users.noreply.github.com>

* adding missing fabric attributes (#500)

* adding missing fabric attributes

* added switch removals an additions into the ebgp_vxlan fabrics

* adding l3vni without vlan

* Sync with netascode/ebgp_vxlan_support branch. 0 files changed (#510)

Hi team, I need to clean up my environment, and for that, I've created the PR. However, there are NO CHANGES IN FILES, so the PR WON'T CHANGE ANYTHING.

Thanks :)

* revert changes back to what is in develop

* Adding possibility to configure policies under ebgp fabric (#506)

* adding missing fabric attributes

* added switch removals an additions into the ebgp_vxlan fabrics

* enabling policy configurations in the ebgp fabric

* correcting vars

* Update sub_main_ebgp_vxlan.yml

The file has been updated with PR #507

* fabric.yml

* Update sub_main_ebgp_vxlan.yml

* replacing symlink with copy of validation file 501

---------

Co-authored-by: Sławomir Kaszlikowski <skaszlik@cisco.com>

* VPC for eBPG fabirc (#507)

* test

* test removed

* spine_bgp_asn is actually "nvPairs.BGP_AS" so we can reuse existing vxlan.global.bgp_asn

* Fix for "Multi-AS" option. The SUPER_SPINE_BGP_AS and BGP_AS_MODE where under wrong IF statement

* work in progress

* Switches are adding but playbook is failing on cisco.nac_dc_vxlan.create : Build Switch Hostname Policy Payload from Data Model Update

* Fix for "Adding switches ". The process now works as expected

* VPC support for eBGP fabric type

* Update devices_discovery.yml to the master

* Update devices_discovery.yml

Bringing back the changes I made

* Update sub_main_ebgp_vxlan.yml

Update based on Matt suggestion

* Update sub_main_ebgp_vxlan.yml

Based on Matt conversation

* Update sub_main_ebgp_vxlan.yml

* Update sub_main_ebgp_vxlan.yml

* Update devices_discovery.yml

Sync with PR #506

* Update sub_main_ebgp_vxlan.yml

Move "Remove Fabric vPC Peering" task above "Remove Fabric Switches"

* Update sub_main_ebgp_vxlan.yml

Moving "Remove Fabric Switches" to the last task

* Update sub_main_ebgp_vxlan.yml

* Add missing condition check for VPC "Import Role Tasks" (#516)

* test

* test removed

* spine_bgp_asn is actually "nvPairs.BGP_AS" so we can reuse existing vxlan.global.bgp_asn

* Fix for "Multi-AS" option. The SUPER_SPINE_BGP_AS and BGP_AS_MODE where under wrong IF statement

* work in progress

* Switches are adding but playbook is failing on cisco.nac_dc_vxlan.create : Build Switch Hostname Policy Payload from Data Model Update

* Fix for "Adding switches ". The process now works as expected

* VPC support for eBGP fabric type

* Update devices_discovery.yml to the master

* Update devices_discovery.yml

Bringing back the changes I made

* Update sub_main_ebgp_vxlan.yml

Update based on Matt suggestion

* Update sub_main_ebgp_vxlan.yml

Based on Matt conversation

* Update sub_main_ebgp_vxlan.yml

* Update sub_main_ebgp_vxlan.yml

* Update devices_discovery.yml

Sync with PR #506

* Update sub_main_ebgp_vxlan.yml

Move "Remove Fabric vPC Peering" task above "Remove Fabric Switches"

* Update sub_main_ebgp_vxlan.yml

Moving "Remove Fabric Switches" to the last task

* Update sub_main_ebgp_vxlan.yml

* Missing condition check

* Ebgp vxlan support interfaces v1 (#515)

* adding missing fabric attributes

* added switch removals an additions into the ebgp_vxlan fabrics

* adding l3vni without vlan

* adding interface config support to ebgp fabric

* adding vpc interfaces after vpc support was merged

* introducing changes requested by the reviewer

* changes requested by reviewer

* EBGP fabric :: enabling hourly_backup (#526)

* adding missing fabric attributes

* added switch removals an additions into the ebgp_vxlan fabrics

* adding l3vni without vlan

* adding interface config support to ebgp fabric

* ebgp fabric creation in ND4.1 + hourly backup

* removing unnecessary comment

* removing unnecessary comment

* removing ND4.1 condition for ALLOW_L3VNI_WO_VLAN

* VRF support for eBGP (#517)

* test

* test removed

* spine_bgp_asn is actually "nvPairs.BGP_AS" so we can reuse existing vxlan.global.bgp_asn

* Fix for "Multi-AS" option. The SUPER_SPINE_BGP_AS and BGP_AS_MODE where under wrong IF statement

* [WIP] VRF enabled but no config on NDFC.

* VRF Support

* Use common files for managing VRFs for both eBGP and iBGP fabrics

* Add 'common_vxlan' only for 'VXLAN_EVPN' and 'eBGP_VXLAN' type of fabric

* clean up task name

* remove white space

* Update vrfs_networks.yml

Update vars_common_local in line 88

* J2 if check

---------

Co-authored-by: Matt Tarkington <mtarking@cisco.com>

* Overlay networks support for eBGP fabric type (#549)

* Menaging_overlay_networks_for_eBGP_fabric

* Removed extra space

* New line inserted

* Add support for ipv6 route map under vrf (#563) (#577)

* adding support for ipv6 route map under vrf

* ipv6 rm

* v6_rm_v1

* fixing child fabric attributes

* fixing v6VrfRouteMap for ND 4.x

* added version checks in the templates

Co-authored-by: mkilar123 <mkilar@cisco.com>

* Change data model from global to global.ebgp (#580)

* Add support for ipv6 route map under vrf (#563)

* adding support for ipv6 route map under vrf

* ipv6 rm

* v6_rm_v1

* fixing child fabric attributes

* fixing v6VrfRouteMap for ND 4.x

* added version checks in the templates

* Migration from global. to global.ebgp.

---------

Co-authored-by: mkilar123 <mkilar@cisco.com>

* update mvpn vri id range enablement name

* updates based on standup meeting

* update defaults

* Update data_model_keys.py

---------

Co-authored-by: Sławomir Kaszlikowski <skaszlik@cisco.com>
Co-authored-by: Matt Tarkington <mtarking@cisco.com>
Co-authored-by: juburnet <145139118+juburnet@users.noreply.github.com>
Co-authored-by: mkilar123 <mkilar@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review PR Ready for Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SGT and Underlay IPV6 is available after 12.2.x and should not be used before.

2 participants