Skip to content

fix condition on ndfc_underlay_ip_address.j2 - #546

Merged
mikewiebe merged 1 commit into
netascode:developfrom
ccoueffe:fix_ndfc_underlay_ip_address-template
Aug 25, 2025
Merged

fix condition on ndfc_underlay_ip_address.j2#546
mikewiebe merged 1 commit into
netascode:developfrom
ccoueffe:fix_ndfc_underlay_ip_address-template

Conversation

@ccoueffe

@ccoueffe ccoueffe commented Aug 8, 2025

Copy link
Copy Markdown
Collaborator

Related Issue(s)

Fix issue when ipv4 is not defined. Which could be the case with fabric Peering + unnumbered.

TASK [cisco.nac_dc_vxlan.common : Build underlay IP address allocation From Template] ********************************************************************************************************************************
Friday 08 August 2025  17:24:36 +0200 (0:00:00.014)       0:00:30.534 ********* 
Friday 08 August 2025  17:24:36 +0200 (0:00:00.014)       0:00:30.534 ********* 
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleUndefinedVariable: 'dict object' has no attribute 'ipv4'
fatal: [nac-ndfc3 -> localhost]: FAILED! => {"changed": false, "msg": "AnsibleUndefinedVariable: 'dict object' has no attribute 'ipv4'"}

PLAY RECAP ***********************************************************************************************************************************************************************************************************
nac-ndfc3                  : ok=210  changed=28   unreachable=0    failed=1    skipped=65   rescued=0    ignored=0   

Related Collection Role

  • cisco.nac_dc_vxlan.validate
  • cisco.nac_dc_vxlan.dtc.create
  • cisco.nac_dc_vxlan.dtc.deploy
  • cisco.nac_dc_vxlan.dtc.remove
  • other

Related Data Model Element

  • vxlan.fabric
  • vxlan.global
  • vxlan.topology
  • vxlan.underlay
  • vxlan.overlay
  • vxlan.overlay_extensions
  • vxlan.policy
  • vxlan.multisite
  • defaults.vxlan
  • other

Proposed Changes

Test Notes

Cisco NDFC Version

Checklist

  • Latest commit is rebased from develop with merge conflicts resolved
  • New or updates to documentation has been made accordingly
  • Assigned the proper reviewers

@ccoueffe
ccoueffe marked this pull request as ready for review August 8, 2025 16:09
@ccoueffe
ccoueffe requested a review from a team as a code owner August 8, 2025 16:09
@ccoueffe ccoueffe self-assigned this Aug 8, 2025
@ccoueffe
ccoueffe requested a review from mikewiebe August 8, 2025 16:11
@ccoueffe ccoueffe added the ready for review PR Ready for Review label Aug 8, 2025
Comment thread roles/dtc/common/templates/ndfc_underlay_ip_address.j2
@ccoueffe
ccoueffe requested a review from mikewiebe August 10, 2025 09:48
@mikewiebe mikewiebe added the 0.5.0 Release 0.5.0 label Aug 21, 2025
@mikewiebe
mikewiebe merged commit 86f12b6 into netascode:develop Aug 25, 2025
8 checks passed
@ccoueffe
ccoueffe deleted the fix_ndfc_underlay_ip_address-template branch March 3, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.5.0 Release 0.5.0 ready for review PR Ready for Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants