Skip to content

Check for whitespace in vlan_name #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mthurstocisco wants to merge 1 commit into from
Closed

Check for whitespace in vlan_name #761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions roles/validate/files/rules/common_vxlan/403_overlay_networks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,12 @@ def match(cls, data_model):
# networks = data_model["vxlan"]["overlay_services"]["networks"]

for network in networks:
current_vlan_name = network.get("vlan_name", None)
if current_vlan_name is not None and ' ' in str(current_vlan_name):
results.append(
f"vxlan.overlay.networks.{network['name']}.vlan_name must not contain whitespace."
)

current_network_netflow_status = network.get("netflow_enable", None)
if current_network_netflow_status is not None:
if fabric_netflow_status is False and current_network_netflow_status is True:
Expand Down
6 changes: 6 additions & 0 deletions roles/validate/files/rules/multisite/204_overlay_networks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ def match(cls, data_model):
if 'networks' in check['keys_found'] and 'networks' in check['keys_data']:
networks = data_model['vxlan']['multisite']['overlay']['networks']
for network in networks:
current_vlan_name = network.get("vlan_name", None)
if current_vlan_name is not None and ' ' in str(current_vlan_name):
results.append(
f"vxlan.multisite.overlay.networks.{network['name']}.vlan_name must not contain whitespace."
)

for attr in network:
if attr in child_fabric_attributes:
results.append(cls.msg.format(network['name'], attr))
Expand Down
Loading