Skip to content

Adding support for storm control on L2 interfaces and copy description on PC #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtarking merged 16 commits into from
Aug 7, 2026
Merged

Adding support for storm control on L2 interfaces and copy description on PC #855

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
c3c6163
update defaults
juarocha Jul 24, 2026
8f402be
adding support for storm control
juarocha Jul 24, 2026
5adc6aa
adding support for storm control on vpcs
juarocha Jul 24, 2026
79ca2c9
adding rule for storm control
juarocha Jul 24, 2026
124115d
Fix PEP8 error
juarocha Jul 24, 2026
3bd442b
updating rule
juarocha Jul 24, 2026
5b7c8c1
Merge branch 'develop' into enhancement/description_storm-control
juarocha Jul 28, 2026
2f33aea
fixed defaults for copy description on trunk po
juarocha Jul 29, 2026
bb66b7c
Fixing rule per interface
juarocha Jul 30, 2026
f16ed1b
add condition to valdiate only when storm control is active
juarocha Jul 30, 2026
b7c0ba4
Merge branch 'netascode:develop' into enhancement/description_storm-c…
juarocha Jul 30, 2026
dd9a268
fixing duplicate vpc id issue
juarocha Jul 30, 2026
8607162
Merge branch 'netascode:develop' into enhancement/description_storm-c…
juarocha Aug 3, 2026
facdb6a
Fixing rules
juarocha Aug 3, 2026
318b9cd
Fixing storm control rule logic
juarocha Aug 5, 2026
21d215e
Adding constraint on templates for ND 4.1
juarocha Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions roles/dtc/common/templates/ndfc_interfaces/ndfc_interface_access.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,28 @@
queuing_policy: {{ interface['queuing_policy'] | default("") }}
{% endif %}
enable_monitor: {{ interface['monitor'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_access_interface.monitor) | lower }}
enable_storm_control: {{ interface['enable_storm_control'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_access_interface.enable_storm_control) | lower }}
{% if interface['enable_storm_control'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_access_interface.enable_storm_control) %}
storm_control_action: {{ interface['storm_control_action'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_access_interface.storm_control_action) | lower }}
{% if interface['storm_control_broadcast_level_percent'] is defined %}
storm_control_broadcast_level_percent: "{{ '%0.2f' % interface['storm_control_broadcast_level_percent'] }}"
{% endif %}
{% if interface['storm_control_multicast_level_percent'] is defined %}
storm_control_multicast_level_percent: "{{ '%0.2f' % interface['storm_control_multicast_level_percent'] }}"
{% endif %}
{% if interface['storm_control_unicast_level_percent'] is defined %}
storm_control_unicast_level_percent: "{{ '%0.2f' % interface['storm_control_unicast_level_percent'] }}"
{% endif %}
{% if interface['storm_control_broadcast_level_pps'] is defined %}
storm_control_broadcast_level_pps: {{ interface['storm_control_broadcast_level_pps'] }}
{% endif %}
{% if interface['storm_control_multicast_level_pps'] is defined %}
storm_control_multicast_level_pps: {{ interface['storm_control_multicast_level_pps'] }}
{% endif %}
{% if interface['storm_control_unicast_level_pps'] is defined %}
storm_control_unicast_level_pps: {{ interface['storm_control_unicast_level_pps'] }}
{% endif %}
{% endif %}
cmds: |2-
{{ interface['freeform_config'] | default('') | indent(6, false) }}
{% endif %}
Expand Down
23 changes: 23 additions & 0 deletions roles/dtc/common/templates/ndfc_interfaces/ndfc_interface_access_po.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
enable_cdp: {{ interface['enable_cdp'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_access_po_interface.enable_cdp) | lower }}
mode: 'access'
description: "{{ interface['description'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_access_po_interface.description) }}"
copy_description: {{ interface['copy_description'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_access_po_interface.copy_description) | lower }}
mtu: {{ interface['mtu'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_access_po_interface.mtu) }}
speed: {{ interface['speed'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_access_po_interface.speed) }}
port_type_fast: {{ interface['spanning_tree_portfast'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_access_po_interface.spanning_tree_portfast) }}
Expand All @@ -44,6 +45,28 @@
queuing_policy: {{ interface['queuing_policy'] | default("") }}
{% endif %}
enable_monitor: {{ interface['monitor'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_access_po_interface.monitor) | lower }}
enable_storm_control: {{ interface['enable_storm_control'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_access_po_interface.enable_storm_control) | lower }}
{% if interface['enable_storm_control'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_access_po_interface.enable_storm_control) %}
storm_control_action: {{ interface['storm_control_action'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_access_po_interface.storm_control_action) | lower }}
{% if interface['storm_control_broadcast_level_percent'] is defined %}
storm_control_broadcast_level_percent: "{{ '%0.2f' % interface['storm_control_broadcast_level_percent'] }}"
{% endif %}
{% if interface['storm_control_multicast_level_percent'] is defined %}
storm_control_multicast_level_percent: "{{ '%0.2f' % interface['storm_control_multicast_level_percent'] }}"
{% endif %}
{% if interface['storm_control_unicast_level_percent'] is defined %}
storm_control_unicast_level_percent: "{{ '%0.2f' % interface['storm_control_unicast_level_percent'] }}"
{% endif %}
{% if interface['storm_control_broadcast_level_pps'] is defined %}
storm_control_broadcast_level_pps: {{ interface['storm_control_broadcast_level_pps'] }}
{% endif %}
{% if interface['storm_control_multicast_level_pps'] is defined %}
storm_control_multicast_level_pps: {{ interface['storm_control_multicast_level_pps'] }}
{% endif %}
{% if interface['storm_control_unicast_level_pps'] is defined %}
storm_control_unicast_level_pps: {{ interface['storm_control_unicast_level_pps'] }}
{% endif %}
{% endif %}
cmds: |2-
{{ interface['freeform_config'] | default('') | indent(6, false) }}
{% endif %}
Expand Down
22 changes: 22 additions & 0 deletions roles/dtc/common/templates/ndfc_interfaces/ndfc_interface_dot1q.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,28 @@
duplex: {{ interface['duplex'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_dot1q_interface.duplex) }}
{% if interface['orphan_port'] | default(false) %}
orphan_port: {{ interface['orphan_port'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_dot1q_interface.orphan_port) | lower }}
{% endif %}
enable_storm_control: {{ interface['enable_storm_control'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_dot1q_interface.enable_storm_control) | lower }}
{% if interface['enable_storm_control'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_dot1q_interface.enable_storm_control) %}
storm_control_action: {{ interface['storm_control_action'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_dot1q_interface.storm_control_action) | lower }}
{% if interface['storm_control_broadcast_level_percent'] is defined %}
storm_control_broadcast_level_percent: "{{ '%0.2f' % interface['storm_control_broadcast_level_percent'] }}"
{% endif %}
{% if interface['storm_control_multicast_level_percent'] is defined %}
storm_control_multicast_level_percent: "{{ '%0.2f' % interface['storm_control_multicast_level_percent'] }}"
{% endif %}
{% if interface['storm_control_unicast_level_percent'] is defined %}
storm_control_unicast_level_percent: "{{ '%0.2f' % interface['storm_control_unicast_level_percent'] }}"
{% endif %}
{% if interface['storm_control_broadcast_level_pps'] is defined %}
storm_control_broadcast_level_pps: {{ interface['storm_control_broadcast_level_pps'] }}
{% endif %}
{% if interface['storm_control_multicast_level_pps'] is defined %}
storm_control_multicast_level_pps: {{ interface['storm_control_multicast_level_pps'] }}
{% endif %}
{% if interface['storm_control_unicast_level_pps'] is defined %}
storm_control_unicast_level_pps: {{ interface['storm_control_unicast_level_pps'] }}
{% endif %}
{% endif %}
cmds: |2-
{{ interface['freeform_config'] | default('') | indent(6, false) }}
Expand Down
1 change: 1 addition & 0 deletions roles/dtc/common/templates/ndfc_interfaces/ndfc_interface_po_routed.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
ipv4_mask_len: {{ ipv4_address__mask[1] | default(omit) }}
{% endif %}
description: "{{ interface['description'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_routed_po_interface.description) }}"
copy_description: {{ interface['copy_description'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_routed_po_interface.copy_description) | lower }}
route_tag: {{ interface['ipv4_route_tag'] | default(omit) }}
int_vrf: {{ interface['vrf'] | default(omit) }}
mtu: {{ interface['mtu'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_routed_po_interface.mtu) }}
Expand Down
22 changes: 22 additions & 0 deletions roles/dtc/common/templates/ndfc_interfaces/ndfc_interface_trunk.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,28 @@
queuing_policy: {{ interface['queuing_policy'] | default("") }}
{% endif %}
enable_monitor: {{ interface['monitor'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_trunk_interface.monitor) | lower }}
enable_storm_control: {{ interface['enable_storm_control'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_trunk_interface.enable_storm_control) | lower }}
{% if interface['enable_storm_control'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_trunk_interface.enable_storm_control) %}
storm_control_action: {{ interface['storm_control_action'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_trunk_interface.storm_control_action) | lower }}
{% if interface['storm_control_broadcast_level_percent'] is defined %}
storm_control_broadcast_level_percent: "{{ '%0.2f' % interface['storm_control_broadcast_level_percent'] }}"
{% endif %}
{% if interface['storm_control_multicast_level_percent'] is defined %}
storm_control_multicast_level_percent: "{{ '%0.2f' % interface['storm_control_multicast_level_percent'] }}"
{% endif %}
{% if interface['storm_control_unicast_level_percent'] is defined %}
storm_control_unicast_level_percent: "{{ '%0.2f' % interface['storm_control_unicast_level_percent'] }}"
{% endif %}
{% if interface['storm_control_broadcast_level_pps'] is defined %}
storm_control_broadcast_level_pps: {{ interface['storm_control_broadcast_level_pps'] }}
{% endif %}
{% if interface['storm_control_multicast_level_pps'] is defined %}
storm_control_multicast_level_pps: {{ interface['storm_control_multicast_level_pps'] }}
{% endif %}
{% if interface['storm_control_unicast_level_pps'] is defined %}
storm_control_unicast_level_pps: {{ interface['storm_control_unicast_level_pps'] }}
{% endif %}
{% endif %}
cmds: |2-
{{ interface['freeform_config'] | default('') | indent(6, false) }}
{% endif %}
Expand Down
23 changes: 23 additions & 0 deletions roles/dtc/common/templates/ndfc_interfaces/ndfc_interface_trunk_po.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
enable_cdp: {{ interface['enable_cdp'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_trunk_po_interface.enable_cdp) | lower }}
mode: 'trunk'
description: "{{ interface['description'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_trunk_po_interface.description) }}"
copy_description: {{ interface['copy_description'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_access_po_interface.copy_description) | lower }}
Comment thread
juarocha marked this conversation as resolved.
Outdated
mtu: {{ interface['mtu'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_trunk_po_interface.mtu) }}
speed: {{ interface['speed'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_trunk_po_interface.speed) }}
port_type_fast: {{ interface['spanning_tree_portfast'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_trunk_po_interface.spanning_tree_portfast) }}
Expand All @@ -46,6 +47,28 @@
queuing_policy: {{ interface['queuing_policy'] | default("") }}
{% endif %}
enable_monitor: {{ interface['monitor'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_trunk_po_interface.monitor) | lower }}
enable_storm_control: {{ interface['enable_storm_control'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_trunk_po_interface.enable_storm_control) | lower }}
{% if interface['enable_storm_control'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_trunk_po_interface.enable_storm_control) %}
storm_control_action: {{ interface['storm_control_action'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_trunk_po_interface.storm_control_action) | lower }}
{% if interface['storm_control_broadcast_level_percent'] is defined %}
storm_control_broadcast_level_percent: "{{ '%0.2f' % interface['storm_control_broadcast_level_percent'] }}"
{% endif %}
{% if interface['storm_control_multicast_level_percent'] is defined %}
storm_control_multicast_level_percent: "{{ '%0.2f' % interface['storm_control_multicast_level_percent'] }}"
{% endif %}
{% if interface['storm_control_unicast_level_percent'] is defined %}
storm_control_unicast_level_percent: "{{ '%0.2f' % interface['storm_control_unicast_level_percent'] }}"
{% endif %}
{% if interface['storm_control_broadcast_level_pps'] is defined %}
storm_control_broadcast_level_pps: {{ interface['storm_control_broadcast_level_pps'] }}
{% endif %}
{% if interface['storm_control_multicast_level_pps'] is defined %}
storm_control_multicast_level_pps: {{ interface['storm_control_multicast_level_pps'] }}
{% endif %}
{% if interface['storm_control_unicast_level_pps'] is defined %}
storm_control_unicast_level_pps: {{ interface['storm_control_unicast_level_pps'] }}
{% endif %}
{% endif %}
cmds: |2-
{{ interface['freeform_config'] | default('') | indent(6, false) }}
{% endif %}
Expand Down
Loading
Loading