Skip to content

Add FEC support for physical interfaces (NDFC 12.4.1+) #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ccoueffe wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Add FEC support for physical interfaces (NDFC 12.4.1+) #856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e87f5ec
update templates for physical interface access, trunk, dot1q and rout…
ccoueffe Jul 27, 2026
7e303f7
Update ndfc_interface_access.j2
ccoueffe Jul 31, 2026
1175c1a
Update ndfc_interface_dot1q.j2
ccoueffe Jul 31, 2026
e45b323
Update ndfc_interface_routed.j2
ccoueffe Jul 31, 2026
c188c10
Update ndfc_interface_trunk.j2
ccoueffe Jul 31, 2026
7a621af
Merge branch 'develop' into feat/Forwarding_Error_Correction
ccoueffe Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions roles/dtc/common/templates/ndfc_interfaces/ndfc_interface_access.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
{% endif %}
enable_monitor: {{ interface['monitor'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_access_interface.monitor) | lower }}
{% if ndfc_version | cisco.nac_dc_vxlan.version_compare('12.4.1', '>=') %}
fec: "{{ interface['fec'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_access_interface.fec) }}"
enable_storm_control: {{ interface['enable_storm_control'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_access_interface.enable_storm_control) | lower }}
{% if interface['enable_storm_control'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_access_interface.enable_storm_control) %}
storm_control_action: {{ interface['storm_control_action'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_access_interface.storm_control_action) | lower }}
Expand Down
1 change: 1 addition & 0 deletions roles/dtc/common/templates/ndfc_interfaces/ndfc_interface_dot1q.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
orphan_port: {{ interface['orphan_port'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_dot1q_interface.orphan_port) | lower }}
{% endif %}
{% if ndfc_version | cisco.nac_dc_vxlan.version_compare('12.4.1', '>=') %}
fec: "{{ interface['fec'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_dot1q_interface.fec) }}"
enable_storm_control: {{ interface['enable_storm_control'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_dot1q_interface.enable_storm_control) | lower }}
{% if interface['enable_storm_control'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_dot1q_interface.enable_storm_control) %}
storm_control_action: {{ interface['storm_control_action'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_dot1q_interface.storm_control_action) | lower }}
Expand Down
3 changes: 3 additions & 0 deletions roles/dtc/common/templates/ndfc_interfaces/ndfc_interface_routed.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@
{% if interface['enable_qos'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_routed_interface.enable_qos) %}
qos_policy: {{ interface['qos_policy'] | default("") }}
queuing_policy: {{ interface['queuing_policy'] | default("") }}
{% endif %}
{% if ndfc_version | cisco.nac_dc_vxlan.version_compare('12.4.1', '>=') %}
fec: "{{ interface['fec'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_routed_interface.fec) }}"
{% endif %}
cmds: |2-
{{ interface['freeform_config'] | default('') | indent(6, false) }}
Expand Down
1 change: 1 addition & 0 deletions roles/dtc/common/templates/ndfc_interfaces/ndfc_interface_trunk.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
{% endif %}
enable_monitor: {{ interface['monitor'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_trunk_interface.monitor) | lower }}
{% if ndfc_version | cisco.nac_dc_vxlan.version_compare('12.4.1', '>=') %}
fec: "{{ interface['fec'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_trunk_interface.fec) }}"
enable_storm_control: {{ interface['enable_storm_control'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_trunk_interface.enable_storm_control) | lower }}
{% if interface['enable_storm_control'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_trunk_interface.enable_storm_control) %}
storm_control_action: {{ interface['storm_control_action'] | default(defaults.vxlan.topology.switches.interfaces.topology_switch_trunk_interface.storm_control_action) | lower }}
Expand Down
4 changes: 4 additions & 0 deletions roles/validate/files/defaults.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ factory_defaults:
orphan_port: false
enable_qos: false
monitor: false
fec: auto
enable_storm_control: false
storm_control_action: default
topology_switch_trunk_interface:
Expand All @@ -191,6 +192,7 @@ factory_defaults:
native_vlan: ""
enable_qos: false
monitor: false
fec: auto
enable_storm_control: false
storm_control_action: default
topology_switch_access_po_interface:
Expand Down Expand Up @@ -247,6 +249,7 @@ factory_defaults:
enable_bpdu_guard: true
duplex: auto
orphan_port: false
fec: auto
enable_storm_control: false
storm_control_action: default
topology_switch_routed_interface:
Expand All @@ -255,6 +258,7 @@ factory_defaults:
speed: auto
enabled: true
enable_qos: false
fec: auto
topology_switch_routed_sub_interface:
description: "NetAsCode Routed Sub Interface"
mtu: 9216
Expand Down
Loading