fix ipv4 subnet mask with manual allocation ebgp - #860
Open
ccoueffe wants to merge 1 commit into
Open
Conversation
ccoueffe
marked this pull request as ready for review
July 31, 2026 17:11
mikewiebe
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Fixes missing
SUBNET_TARGET_MASKin eBGP VXLAN fabric payload whenmanual_underlay_allocationis enabled.Related Collection Role
roles/dtc/common/templates/ndfc_fabric/ebgp_vxlan_fabric/general/Related Data Model Element
Proposed Changes
The
SUBNET_TARGET_MASKparameter was nested inside themanual_underlay_allocation == falseguard in the eBGP fabric template. This meant that when using manual underlay allocation, the subnet mask was not sent to NDFC — causing fabric creation/update to use NDFC defaults instead of the user-defined value.SUBNET_TARGET_MASKis required by NDFC regardless of whether IP allocation is manual or automatic — it defines the point-to-point link prefix length for the underlay. The only condition where it should be omitted is when IPv6 underlay is enabled (since IPv6 uses a different parameter).Fix: Moved
SUBNET_TARGET_MASKoutside themanual_underlay_allocationguard, keeping only theenable_ipv6_underlaycondition:manual=false,ipv6=falsemanual=true,ipv6=falsemanual=false,ipv6=truemanual=true,ipv6=trueTest Notes
Tested with eBGP VXLAN fabric using
manual_underlay_allocation: trueandsubnet_mask: 30. Verified:SUBNET_TARGET_MASK: "30"now appears in the fabric payload ✅SUBNET_RANGEremains correctly omitted for manual allocation ✅SUBNET_TARGET_MASK✅Cisco Nexus Dashboard Version
ND 4.1+
Checklist