-
Notifications
You must be signed in to change notification settings - Fork 69
Changed VolumeMode to PersistentVolumeBlock #1094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Deblazz
wants to merge
43
commits into
netgroup-polito:master
Choose a base branch
from
Deblazz:feature_vdd-fs-to-block
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 4 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
eceffde
Changed VolumeMode to PersistentVolumeBlock
Deblazz 718016e
Change PVC access mode to ReadWriteMany
abellonioandrea 7842825
Merge branch 'master' into feature_vdd-fs-to-block
abellonioandrea 021b249
Added networking annotation for allowing live migration
abellonioandrea db96023
revert last commit
abellonioandrea 1e71c69
Merge branch 'master' into feature_vdd-fs-to-block
abellonioandrea fb85af8
TEST: implement clone from pvc in operator
Deblazz 276ab5c
fix lint and test commented (only for now)
abellonioandrea 2e813bf
Fixed indent
Deblazz 25b5822
test passing to pmp
abellonioandrea 7e93308
Merge branch 'master' into feature_vdd-fs-to-block
abellonioandrea 3bb64bf
Add Block volume support to pmp
AleTopp cf8025c
Fix ptr deref
AleTopp af4ca3c
Merge branch 'master' into feature_vdd-fs-to-block
QcFe 0ef94d2
revert pmp migration
abellonioandrea 44fe47e
fix go linting
abellonioandrea 03d2c0f
removed tests for pmp implementation
abellonioandrea db015ad
adding rolebinding for cdi clone
abellonioandrea ea60550
namespace change
abellonioandrea a5e4f36
moving rolebinding to user namespace
abellonioandrea e3ed4d6
Merge branch 'master' into feature_vdd-fs-to-block
abellonioandrea 226bf4b
fix namespace value
abellonioandrea c063fd6
fix namespace value
abellonioandrea a9f4de6
Created DataVolume object before VM creation
Deblazz 5119264
Hardcoded datavolumeonce again
Deblazz 047fabf
Merge branch 'master' into feature_vdd-fs-to-block
Deblazz 4f521ce
fixed syntax error
Deblazz 40722b6
Merge branch 'feature_vdd-fs-to-block' of https://github.com/Deblazz/…
Deblazz 530152e
Fixed linting issue
Deblazz 4606bbf
Fixed linting issue again
Deblazz 6bb9c0b
Added test
Deblazz abb046f
Updated destination datavolume to block instead of fs
Deblazz 8c3d178
Merge branch 'master' into feature_vdd-fs-to-block
Deblazz b9615a2
Removed every ref to DataVolumeTemplate
Deblazz fdab548
Merge branch 'feature_vdd-fs-to-block' of https://github.com/Deblazz/…
Deblazz 8ae112f
Updated comments
Deblazz db42191
Added new environment LocalVM, restored CloudVMs
Deblazz bc09fe4
updated manifests
Deblazz 8487ec1
Added localvm in various places
Deblazz d6fa4bb
updated manifests
Deblazz 028bd21
Restored current release rolebindings
Deblazz 58e5314
Updated frontend to list LocalVM
Deblazz 00a6c07
Added custom pvc support for LocalVMs
Deblazz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're theoretically not using bridge mode, is this really needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this, the live migration is not working
To be precise in the virtual machine I am getting this error:
cannot migrate VMI which does not use masquerade, bridge with kubevirt.io/allow-pod-bridge-network-live-migration VM annotation or a migratable plugin to connect to the pod networkThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok but we're supposed to be using masquerade actually...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay I didn't know, so it is only a problem related to the fact we are running vms manually in KubeVirt without the crownlabs infrastructure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will revert the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please check just in case? I added self-edit on your tenant ns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm that on a virtual machine in my tenant namespace I see the same error as before for the live migration enable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that actually VMS are not in Masquerade but are in Bridge mode.
CrownLabs/operators/pkg/forge/virtualmachines.go
Line 88 in 620c972
DefaultBridgeNetworkInterface must be changed to DefaultMasqueradeNetworkInterface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this explains several things. I'd say it's better to discuss this tonight at the weekly in order to understand together if there could be further implications by switching this...