Refactor to use a cleanup object for timeouts: stopAfterInactivity, deleteAfterInactivity, and deleteAfterCreation.#1145
Draft
vmoliterno wants to merge 82 commits into
Draft
Conversation
…tored delete to destroy, changed values for staging test in values.yaml
- Added missing configuration flags to instance-automation operator, including destruction notification intervals and testing overrides. - Refactored InstanceInactiveTerminationReconciler to improve readability and robustness of the destruction logic for powered-off instances. - Standardized logging across destruction helper functions and added proper error handling for annotation parsing. - Fixed a bug where destruction notifications used the wrong interval flag. - Integrated LastPoweredOffTimestampAnnotation in the termination reconciler to ensure the destruction countdown starts whenever an instance is stopped. - Updated Helm chart templates and values to correctly propagate the new automation configurations to the deployed containers.
feat: add DestroyAfterInactivity feature for permanent VM destruction
…ion to controller
Instance off annotation logic
Fixed CI errors
…ownLabs into feature-Deletion
Added tests and changed prometheusURL
… the instances will be deleted after the destroyAfterInactivity time even if value for email notification is false
…ModalCreateTemplate view and logic to connect this value to backend
Added modification to front-end to gather destroyAfterInactivity value
vmoliterno
changed the base branch from
master
to
copilot/bugfix-exam-agent-api-inconsistency
vmoliterno
changed the base branch from
copilot/bugfix-exam-agent-api-inconsistency
to
master
Contributor
|
/deploy-staging |
…te creation, changed 'Expiration' to 'Expire'
Contributor
|
/deploy-staging |
Collaborator
|
Your staging environment has been correctly deployed.
|
Contributor
|
/deploy-staging |
Contributor
|
/deploy-staging |
Collaborator
|
Your staging environment has been correctly deployed.
|
1 similar comment
Collaborator
|
Your staging environment has been correctly deployed.
|
Contributor
|
/deploy-staging |
Collaborator
|
Your staging environment has been correctly deployed.
|
Contributor
|
/deploy-staging |
Collaborator
|
Something went wrong while deploying your staging environment! |
Collaborator
|
Your staging environment has been correctly deployed.
|
…ler with one single PatchObject in the reconciler, using the mutation function enforceInstanceMetadata
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a significant refactor and enhancement of the template creation modal's cleanup timeout configuration in the frontend application. The changes standardize and expand how cleanup timeouts are handled, moving from two flat fields to a structured
cleanupobject with three distinct timeout options. Default values for these timeouts are now injected via Helm and exposed to the frontend through environment variables. The UI for configuring these timeouts is also improved with clearer controls, validation, and user guidance.Key changes include:
Backend/Configuration:
defaultTimeouts.cleanupsection in bothdeploy/crownlabs/values.yamlandfrontend/deploy/frontend-app/values.yamlto define default values forstopAfterInactivity,deleteAfterInactivity, anddeleteAfterCreationtimeouts. [1] [2]Frontend Logic & State Management:
ModalCreateTemplate.tsx) to use acleanupobject for timeouts, supporting three distinct settings:stopAfterInactivity,deleteAfterInactivity, anddeleteAfterCreation. All related state management, form handling, and value parsing logic were updated accordingly. [1] [2] [3] [4] [5]