Skip to content

Cloud Image Registry Implementation#917

Open
air-31 wants to merge 1 commit into
masterfrom
ilkh/new-storage-utility
Open

Cloud Image Registry Implementation#917
air-31 wants to merge 1 commit into
masterfrom
ilkh/new-storage-utility

Conversation

@air-31

@air-31 air-31 commented Dec 20, 2024

Copy link
Copy Markdown
Contributor

Description

This PR implements a new component - Cloud Image Registry - created with the purpose to store virtual machines disk files inside a storage within the cluster in order to accelerate persistent template instances creation process, and to avoid using kubevirt containerdisks.

@air-31 air-31 requested a review from a team as a code owner December 20, 2024 16:06
@kingmakerbot

Copy link
Copy Markdown
Collaborator

Hi @air-31. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR (the build-all flag enables user environments building)
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@kingmakerbot

Copy link
Copy Markdown
Collaborator

The go.mod and/or go.sum files appear not to be correctly tidied.

Please, rerun go mod tidy to fix the issues.

@air-31 air-31 force-pushed the ilkh/new-storage-utility branch 2 times, most recently from 28ab466 to 4cf6ad2 Compare January 8, 2025 18:42
@QcFe

QcFe commented Jan 9, 2025

Copy link
Copy Markdown
Collaborator

/deploy-staging

@kingmakerbot

Copy link
Copy Markdown
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-917 label to your tenant.

1 similar comment
@kingmakerbot

Copy link
Copy Markdown
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-917 label to your tenant.

@QcFe

QcFe commented Mar 4, 2025

Copy link
Copy Markdown
Collaborator

Thanks for the latest changes @air-31!
Have a look at the checks to fix the little issues that arose from the renaming to ciregistry, then,
would you mind pull-rebasing from main and simplifying the openapi method names? (removing the "handle" prefix basically)
Eventually please squash the whole thing in a single commit :)

@air-31 air-31 force-pushed the ilkh/new-storage-utility branch from 0eefb94 to 1f79cf0 Compare March 4, 2025 16:12
@air-31 air-31 force-pushed the ilkh/new-storage-utility branch 2 times, most recently from cdcd8cf to 1656acb Compare March 4, 2025 16:53
@air-31

air-31 commented Mar 4, 2025

Copy link
Copy Markdown
Contributor Author

/rebase

@kingmakerbot kingmakerbot force-pushed the ilkh/new-storage-utility branch from 1656acb to 826d4b7 Compare March 4, 2025 17:04
@air-31 air-31 force-pushed the ilkh/new-storage-utility branch from 826d4b7 to 4b9a486 Compare March 4, 2025 17:09
@QcFe

QcFe commented Mar 5, 2025

Copy link
Copy Markdown
Collaborator

/deploy-staging

@kingmakerbot

Copy link
Copy Markdown
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-917 label to your tenant.

@air-31 air-31 force-pushed the ilkh/new-storage-utility branch from 4b9a486 to 930efcb Compare March 5, 2025 15:03
@QcFe

QcFe commented Mar 5, 2025

Copy link
Copy Markdown
Collaborator

/deploy-staging

@kingmakerbot

Copy link
Copy Markdown
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-917 label to your tenant.

@air-31 air-31 force-pushed the ilkh/new-storage-utility branch from 930efcb to 7252cc4 Compare March 12, 2025 17:04
@QcFe

QcFe commented Mar 12, 2025

Copy link
Copy Markdown
Collaborator

/deploy-staging

@kingmakerbot

Copy link
Copy Markdown
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-917 label to your tenant.

@frisso frisso left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@air-31 This looks very good to me.
I would kindly ask you to add a page in the documentation (e.g., https://github.com/netgroup-polito/CrownLabs/tree/master/infrastructure) to briefly describe what this component is about, and the minimal info required to use/configure it (info about extending/updating would be nice as well, but not mandatory)

@air-31 air-31 force-pushed the ilkh/new-storage-utility branch from 7252cc4 to 9195726 Compare March 14, 2025 13:24
@QcFe

QcFe commented Mar 14, 2025

Copy link
Copy Markdown
Collaborator

/deploy-staging

@kingmakerbot

Copy link
Copy Markdown
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-917 label to your tenant.

@air-31 air-31 force-pushed the ilkh/new-storage-utility branch 2 times, most recently from 327d438 to 0937d0f Compare March 17, 2025 22:34
@air-31

air-31 commented Mar 17, 2025

Copy link
Copy Markdown
Contributor Author

/deploy-staging

@kingmakerbot

Copy link
Copy Markdown
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-917 label to your tenant.

@air-31 air-31 force-pushed the ilkh/new-storage-utility branch from 0937d0f to a0b8dc5 Compare March 18, 2025 21:07
@air-31 air-31 force-pushed the ilkh/new-storage-utility branch 2 times, most recently from 5fd7192 to 7947117 Compare April 4, 2025 13:57
@air-31 air-31 force-pushed the ilkh/new-storage-utility branch from 7947117 to a6b0ee8 Compare April 4, 2025 14:39
@air-31

air-31 commented Apr 4, 2025

Copy link
Copy Markdown
Contributor Author

/deploy-staging

@kingmakerbot

Copy link
Copy Markdown
Collaborator

Something went wrong while deploying your staging environment!

@QcFe

QcFe commented Apr 8, 2025

Copy link
Copy Markdown
Collaborator

/deploy-staging

@kingmakerbot

Copy link
Copy Markdown
Collaborator

Something went wrong while deploying your staging environment!

@QcFe

QcFe commented Jan 16, 2026

Copy link
Copy Markdown
Collaborator

/undeploy-staging

@kingmakerbot

Copy link
Copy Markdown
Collaborator

Your staging environment has been correctly teared-down!

@AleTopp AleTopp added the kind/feature New feature or request label Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants