fix(refs): address Copilot review followups from #26#27
Conversation
- advanced-git.md: 'Intellij' -> 'IntelliJ'; 'Setup' -> 'Set up' (verb form); correct 'worktree remove feature-x' to '../feature-x' so the command actually targets the worktree created by the earlier 'worktree add ../feature-x' example (feature-x relative to .bare/ would miss it) - commit-conventions.md: broaden the '-S' rationale to cover gpg-agent and ssh-agent (GPG-SSH) signing — 'SSH agent' alone was misleading for GPG users; split 'never skip hooks' into two rules so the bundled signing flags aren't incorrectly lumped under hook-bypass Threads: - PRRT_kwDOQoBsD858Z5FF (worktree path) - PRRT_kwDOQoBsD858Z5Fg (signing agent) - PRRT_kwDOQoBsD858Z5Fv (hooks vs signing) - PRRT_kwDOQoBsD858Z5F4 (IntelliJ) - PRRT_kwDOQoBsD858Z5GC (Set up) Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves the Git workflow documentation by correcting typos, fixing a relative path in a worktree removal example, and refining the guidelines for commit signing and hook bypasses. A review comment points out a technical inaccuracy regarding how Git handles signing failures when global configuration is used, suggesting a more precise explanation for why the explicit -S flag is necessary in isolated environments.
There was a problem hiding this comment.
Pull request overview
Follow-up documentation refinements to the git-workflow skill references, incorporating review feedback from PR #26 and clarifying guidance around worktrees and commit signing.
Changes:
- Fix IntelliJ capitalization and “Set up” verb form in
advanced-git.md. - Correct the
git worktree removepath so it targets the worktree created by the earlierworktree addcommand. - Clarify commit signing rationale and separate “skip hooks” vs “bypass signing” guidance in
commit-conventions.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| skills/git-workflow/references/commit-conventions.md | Clarifies the signing-agent explanation for -S and splits hook-bypass vs signing-bypass rules. |
| skills/git-workflow/references/advanced-git.md | Fixes product capitalization/grammar and corrects the worktree removal path to match the documented layout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fix(commit-conventions): address Copilot second-sweep finding from #27
Follow-up to Copilot review comments on the bare-worktree + signed-commits refs merged in #26:
Changes
advanced-git.md:Intellij->IntelliJ(correct product capitalization)**Setup a new project this way:**->**Set up a new project this way:**(verb form)git -C .bare worktree remove ../feature-xso the path targets the worktree that the earlierworktree add ../feature-xactually created (a relativefeature-xfrom.bare/would miss it)commit-conventions.md:-Srationale from 'SSH agent' to 'signing agent (gpg-agent, or ssh-agent when usinggpg.format=ssh)' — the previous wording conflated the two. GPG-only users havegpg-agent+ pinentry; only GPG-SSH users see SSH-agent involvement.--no-verify) and signing (--no-gpg-sign/commit.gpgsign=false). They were incorrectly bundled —--no-gpg-signdisables signing, it does not bypass hooks.Thread IDs resolved after merge