fix(commit-conventions): refine -S rationale per #28 review#29
Merged
Conversation
Make the two failure modes unambiguous: (1) without loaded config, git doesn't attempt to sign at all and records unsigned silently; (2) with -S, git always attempts, so a missing/unreachable signing agent causes a noisy abort. Prefer 'records unsigned' over 'ships unsigned' since this happens at commit time, not push time. Thread: PRRT_kwDOQoBsD858lNtu Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
Refines the documentation rationale for requiring explicit git commit -S so it clearly distinguishes between “config not loaded → git never attempts signing” vs “-S present → git attempts signing and fails loudly if signing can’t happen”, aligning with the review feedback from #28.
Changes:
- Rewrites the “Why explicit
-S” section to explicitly describe the two signing failure modes. - Updates wording from push-time framing (“ships unsigned”) to commit-time framing (“records unsigned”).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CybotTM
added a commit
that referenced
this pull request
Apr 21, 2026
fix(commit-conventions): grammar fix per #29 review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further Copilot review on #28 asked to distinguish two failure modes unambiguously. Applied.
Change
Rewrite the second half of 'Why explicit
-S' so the two cases are explicit:-S: git always attempts. A missing signing agent or unreachable pinentry aborts noisily.Also use 'records unsigned' (commit-time) instead of 'ships unsigned' (push-time).
Thread resolved after merge
PRRT_kwDOQoBsD858lNtu