fix(commit-conventions): grammar fix per #29 review#30
Merged
Conversation
'The commit records unsigned' was ungrammatical (commit is the object, not the subject of 'records'). Rewrite as 'Git records the commit as unsigned' so the subject/action is clear. Thread: PRRT_kwDOQoBsD858obDy Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
Updates the Git workflow documentation to clarify the rationale for using explicit commit-signing flags, addressing a grammar issue noted in a prior review thread.
Changes:
- Rephrases a sentence in the “Why explicit
-S” section to use a clearer subject/action (“Git records the commit as unsigned…”).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot flagged 'The commit records unsigned' as ungrammatical. Rewritten as 'Git records the commit as unsigned' so the subject/action is clear.
Thread resolved after merge: PRRT_kwDOQoBsD858obDy