Skip to content

docs(static-analysis): note php-cs-fixer CI/PHP-version parity#63

Merged
CybotTM merged 1 commit into
mainfrom
docs/php-cs-fixer-ci-version-parity
Jun 18, 2026
Merged

docs(static-analysis): note php-cs-fixer CI/PHP-version parity#63
CybotTM merged 1 commit into
mainfrom
docs/php-cs-fixer-ci-version-parity

Conversation

@CybotTM

@CybotTM CybotTM commented Jun 18, 2026

Copy link
Copy Markdown
Member

What

Adds a "Run the toolchain the way CI does (version parity)" section to
references/static-analysis-tools.md, plus a covering eval.

Why

php-cs-fixer applies PHP-version-specific fixers: which rules run and how
they format depend on the PHP version the binary executes under. So
php vendor/bin/php-cs-fixer fix --dry-run on a newer local PHP can report a
file clean while CI — running the style gate on the project's pinned, older PHP
— rewrites it and fails. Observed in practice: a closure formatted fn ( passed
local PHP 8.5 but CI's PHP 8.2 demanded fn(, costing a red gate and a
force-push.

Change

  • Reference guidance: run quality gates through the project's own runner
    (make code-style/make phpstan, a composer script, or a Docker runner) so
    the PHP version matches CI; if calling the binary directly, run it under CI's
    PHP version; note that PHP_CS_FIXER_IGNORE_ENV only silences the warning.
  • New eval cs-fixer-ci-version-parity asserting the diagnosis + the
    run-via-CI-toolchain remedy.

SKILL.md is unchanged and stays under the 500-word cap (guidance lives in the
already-referenced static-analysis-tools.md).

php-cs-fixer applies PHP-version-specific fixers, so a newer local PHP can
report a file clean while CI running on the project's pinned, older PHP
rewrites it and fails the style gate (seen in practice: `fn (` passed local
PHP 8.5 but CI's PHP 8.2 demanded `fn(`).

Document running quality gates via the project's own runner (make / composer
script / Docker) at CI's PHP version in the static-analysis-tools reference,
and add an eval covering the diagnosis. SKILL.md is unchanged (stays under the
500-word cap).

Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
Copilot AI review requested due to automatic review settings June 18, 2026 09:54
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions github-actions Bot added documentation Improvements or additions to documentation skill evals labels Jun 18, 2026
@sonarqubecloud

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@CybotTM CybotTM merged commit cf93bab into main Jun 18, 2026
20 of 21 checks passed
@CybotTM CybotTM deleted the docs/php-cs-fixer-ci-version-parity branch June 18, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation evals skill

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants