D10 compatibility#36
Open
ipwa wants to merge 1 commit into
Open
Conversation
fabianmarz
requested changes
May 8, 2025
fabianmarz
left a comment
fabianmarz
left a comment
Member
There was a problem hiding this comment.
Thank you for your contribution! I just checked and I'm not quite sure what happened in the TwigFractal.php file so would be great if you could check again :-)
| public function getName(): string { | ||
| return 'twig_fractal'; | ||
| } | ||
| class Render extends IncludeNode { |
Member
There was a problem hiding this comment.
Please note you duplicated the methods (not sure if you also made adjustments) from the actual render class https://github.com/ipwa/twig_fractal/blob/master/src/Node/Render.php#L60
could you please double check, whether your adjustments in this file are correct? Also the class and filename do not align anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes [#35]