Skip to content

Hc/more than two parents#45

Draft
HenryCrosswell wants to merge 12 commits into
mainfrom
hc/more-than-two-parents
Draft

Hc/more than two parents#45
HenryCrosswell wants to merge 12 commits into
mainfrom
hc/more-than-two-parents

Conversation

@HenryCrosswell

Copy link
Copy Markdown

Before submitting a pull request (PR), please read the contributing guide.

Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Previous api pulls when multiple parents (1 male and 2 females) are involved would break the request

What does this PR do?
This pull request fixes the Dataframe issue with multiple parents, iterating through and making new columns. In its current state it re-orders the columns well.

References

Closes issue #23

How has this PR been tested?

Currently the testing does not work due to there being too many animal response requests (due to multiple parents) that the parameterise function gives the wrong data as a response. I have set a plan out to address this after my A/L.

Is this a breaking change?

It does modify some existing functions - such as historical stats which will need to be modified to allow multiple parents in the future

Does this PR require an update to the documentation?

Not yet

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@HenryCrosswell HenryCrosswell requested a review from a team June 12, 2026 18:05
@HenryCrosswell HenryCrosswell self-assigned this Jun 12, 2026
…ull mutations for all parent_sex once, adjusted other functions to fit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant