Skip to content

ensure CNAME is 'occupied'#102

Merged
IgorTatarnikov merged 2 commits into
mainfrom
fix-cname
Jun 10, 2026
Merged

ensure CNAME is 'occupied'#102
IgorTatarnikov merged 2 commits into
mainfrom
fix-cname

Conversation

@alessandrofelder

@alessandrofelder alessandrofelder commented Jun 10, 2026

Copy link
Copy Markdown
Member

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Ensure the dashboard website claims the CNAME throughout.

How has this PR been tested?

  • Checked that quarto render locally copies the CNAME into the local build folder, which my AI assistant suggests is key for "claiming" it.
  • Double-checked the action we use to deploy and this seems to allow us to pass a cname as an option

I don't really know how much of this is overkill (setting the cname in the workflow might be enough), but it won't hurt.

@alessandrofelder alessandrofelder marked this pull request as ready for review June 10, 2026 11:32

@IgorTatarnikov IgorTatarnikov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Let's try merging it and re-rendering the website to see if it works.

@IgorTatarnikov IgorTatarnikov merged commit 5d621ee into main Jun 10, 2026
1 check passed
@IgorTatarnikov IgorTatarnikov deleted the fix-cname branch June 10, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants