Fix logging tests#731
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #731 +/- ##
=======================================
Coverage 90.27% 90.27%
=======================================
Files 54 54
Lines 4423 4423
=======================================
Hits 3993 3993
Misses 430 430 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
PolarBean
approved these changes
Jun 19, 2026
Member
Author
|
cheers @PolarBean! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests were failing due to an issue in in which the logger was expected to not have been set up yet, but was persisting, possibly having been set up in another test. This has never been an issue before so not exactly sure what's happening, maybe the order in which the tests are run has changed if pytest in a new version.
The solution is to tear down the logger before and after the offending test.