Skip to content

Fix logging tests#731

Merged
JoeZiminski merged 1 commit into
mainfrom
fix-logging-tests
Jun 19, 2026
Merged

Fix logging tests#731
JoeZiminski merged 1 commit into
mainfrom
fix-logging-tests

Conversation

@JoeZiminski

@JoeZiminski JoeZiminski commented Jun 16, 2026

Copy link
Copy Markdown
Member

Tests were failing due to an issue in in which the logger was expected to not have been set up yet, but was persisting, possibly having been set up in another test. This has never been an issue before so not exactly sure what's happening, maybe the order in which the tests are run has changed if pytest in a new version.

The solution is to tear down the logger before and after the offending test.

@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.27%. Comparing base (31131b3) to head (c52d811).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #731   +/-   ##
=======================================
  Coverage   90.27%   90.27%           
=======================================
  Files          54       54           
  Lines        4423     4423           
=======================================
  Hits         3993     3993           
  Misses        430      430           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoeZiminski JoeZiminski changed the title Try and fix tests. Fix logging tests Jun 19, 2026
@JoeZiminski JoeZiminski requested a review from a team June 19, 2026 16:00
@JoeZiminski

Copy link
Copy Markdown
Member Author

cheers @PolarBean!

@JoeZiminski JoeZiminski merged commit b594660 into main Jun 19, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants