Skip to content

naive adding of support for Python 3.14#736

Merged
JoeZiminski merged 3 commits into
mainfrom
support-3.14
Jun 25, 2026
Merged

naive adding of support for Python 3.14#736
JoeZiminski merged 3 commits into
mainfrom
support-3.14

Conversation

@alessandrofelder

@alessandrofelder alessandrofelder commented Jun 25, 2026

Copy link
Copy Markdown
Member

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

What does this PR do?
This PR

  • ensures the regex inputs in folder.py are Python 3.14 compliant
  • runs tests on Python 3.14

References

Closes #735

How has this PR been tested?

Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.

Does this PR require an update to the documentation?

If any features have changed, or have been added. Please explain how the
documentation has been updated.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@JoeZiminski JoeZiminski marked this pull request as ready for review June 25, 2026 17:59
@JoeZiminski JoeZiminski self-requested a review June 25, 2026 18:02
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.27%. Comparing base (94a5d43) to head (40fdd35).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #736      +/-   ##
==========================================
- Coverage   90.30%   90.27%   -0.03%     
==========================================
  Files          54       54              
  Lines        4423     4423              
==========================================
- Hits         3994     3993       -1     
- Misses        429      430       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoeZiminski

Copy link
Copy Markdown
Member

on PR the oldest and latest python are tested, the patch works for 3.9 and 3.13. Will update the CI to run on 3.14 and test it here. Also tested the the relevant part of the gui on local 3.14 and it worked well

@JoeZiminski JoeZiminski merged commit 3156189 into main Jun 25, 2026
16 of 17 checks passed
@alessandrofelder alessandrofelder deleted the support-3.14 branch June 26, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

string escape character used breaks in Python 3.14

2 participants