Fix custom transfer widgets persisting#740
Merged
Merged
Conversation
JoeZiminski
force-pushed
the
fix_custom_transfer_widgets_persisting
branch
from
d204026 to
21d7c4d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #740 +/- ##
=======================================
Coverage 90.27% 90.28%
=======================================
Files 54 54
Lines 4423 4424 +1
=======================================
+ Hits 3993 3994 +1
Misses 430 430 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Remove unused variables from setup_project_paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in which the widgets for the cumstom transfer could persist after switching back to transfer entire project / top level folder, once the number of checkboxes had been customised. This is because fresh instances of the checkboxes are generated after customising them, but old versions of the widgets persisted in a list that was shown / hidden when the transfer type was changed.
This is fixed by separating these dynamic widgets into their own list which is properly updated. Tests are added.