Skip to content

fix: raise errors correctly in vector.py instead of raise logger.error() #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PewterZz wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: raise errors correctly in vector.py instead of raise logger.error() #894

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ec1629
fix: raise errors correctly in vector.py instead of raise logger.error()
PewterZz Mar 16, 2026
072882c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 12 additions & 13 deletions movement/utils/vector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,21 +268,20 @@ def compute_signed_angle_2d(
elif v.ndim == 2:
v_dims = ["time", "space"]
else:
raise logger.error(
ValueError(f"v must be 1D or 2D, but got {v.ndim}D.")
)
error = ValueError(f"v must be 1D or 2D, but got {v.ndim}D.")
logger.error(error)
raise error
v = xr.DataArray(
v,
dims=v_dims,
coords={d: u.coords[d] for d in v_dims},
)
elif not isinstance(v, xr.DataArray):
raise logger.error(
TypeError(
"v must be an xarray.DataArray or np.ndarray, "
f"but got {type(v)}."
)
error = TypeError(
f"v must be an xarray.DataArray or np.ndarray, but got {type(v)}."
)
logger.error(error)
raise error
validate_dims_coords(v, {"space": ["x", "y"]}, exact_coords=True)

u = convert_to_unit(u)
Expand All @@ -308,9 +307,9 @@ def compute_signed_angle_2d(


def _raise_error_for_missing_spatial_dim() -> NoReturn:
raise logger.error(
ValueError(
"Input data array must contain either 'space' or 'space_pol' "
"as dimensions."
)
error = ValueError(
"Input data array must contain either 'space' or 'space_pol' "
"as dimensions."
)
logger.error(error)
raise error