Improve xarray compatibility in vector utilities (compute_signed_angle_2d and cart2pol) [fixes #901]#902
Open
swagat-mishra28 wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes #901
Summary
While reviewing
movement/utils/vector.py, I noticed a few places where NumPy operations were applied directly to xarrayDataArrayobjects or where.valueswas accessed. These patterns can bypass xarray’s abstraction layer and may cause issues with lazy backends (e.g., dask) or metadata handling.This PR improves compatibility with xarray best practices.
Changes
np.arctan2(cross, dot)withxr.apply_ufunc(np.arctan2, cross, dot)incompute_signed_angle_2d.valueswithxr.where.valuesaccess incart2polRationale
Using xarray-aware operations preserves metadata and ensures compatibility with lazy computation frameworks such as dask.
Testing
All existing tests pass locally:
pytest --ignore=tests/test_unit/test_napari_plugin
Result:
1011 passed, 4 deselected, 2 xfailed
No functional behavior of the library was changed; the modifications only improve implementation safety and compatibility with xarray.