Add Lightning Pose conversion example#56
Conversation
themattinthehatt
changed the title
niksirbi
left a comment
niksirbi
left a comment
There was a problem hiding this comment.
Thanks for the PR @themattinthehatt !
Special kudos for adding that LP fixture which makes the example run reproducible.
I'm pre-approving this PR despite the inline comments I left. Consider my comments optional and feel free to address only those you think are important.
The new gallery example duplicates lots of content from the DLC example, but I think that's fine for now. The problem will improve after we introduce higher-level APIs, as discussed in #50
| # Lightning Pose saves prediction files to the model output directory, | ||
| # **not** to the project's ``videos/`` directory. Before running this | ||
| # script, move (or copy) each session's prediction CSV — and apply any | ||
| # manual corrections you have made — into | ||
| # ``<source_project_dir>/videos/``, named to match the corresponding | ||
| # video stem (e.g. ``<video_stem>.csv``). | ||
|
|
There was a problem hiding this comment.
Is this necessary? predictions_to_poseinterface accepts separate paths for predictions and for video, so should be fine having them in separate folders, unless I'm missing something.
If it's necessary, I wonder how we could help with the copying. For example, we could include a small utility for copying predictions from the model output dir to the videos dir. Similar logic to how we include a split_lp_collected_data utility.
Let me know what you think. We could also open an issue to tackle this later after this PR is merged.
There was a problem hiding this comment.
it's not strictly necessary, for now it's more just to streamline this conversion process and make the script work out-of-the-box. perhaps we revisit this once #50 has been addressed?
Yes, see my comment on the other PR. |
2 participants
Description
What is this PR
Why is this PR needed?
Current repo only contains conversion utilities for DLC projects.
What does this PR do?
Add Lightning Pose conversion: helper functions, small example dataset, and example conversion script.
References
Reuses much of the conversion utilities developed in #49.
How has this PR been tested?
Is this a breaking change?
No.
Does this PR require an update to the documentation?
Yes; a new example has been added at "examples/convert_lp_to_benchmark.py".
Checklist: