Update ownership for uninstrumented entity definitions#2699
Update ownership for uninstrumented entity definitions#2699
Conversation
|
👋 This PR has seen no activity in over 3 days and is still awaiting approval from: @newrelic/BEYOND, @newrelic/OHAI, @newrelic/K8S-AGENTS Please review or provide an update. |
entityBot
dismissed stale reviews from naxhh, nr-ksteinbach, and themself
Dismissing reviews
entityBot
left a comment
entityBot
left a comment
There was a problem hiding this comment.
beep boop bop.
I have found some errors processing these changes:
* Error VALIDATING domainType: 'INFRA-OCIAUTONOMOUSDATABASE' on synthesis - Exception: No entity matches 'INFRA-OCIAUTONOMOUSDATABASE' synthesis rules for the given test data: 'MetricRaw.json file - #1' data point. Please review test data and synthesis rules.
bgalmesnr
force-pushed
the
add-ownership-for-uninstrumented-definitions
branch
from
27813f3 to
c82709c
Compare
…umented counterparts
bgalmesnr
force-pushed
the
add-ownership-for-uninstrumented-definitions
branch
from
c82709c to
d1fd4ab
Compare
| ownership: | ||
| primaryOwner: | ||
| teamName: "no owner" | ||
| teamName: "K8s Agents" |
There was a problem hiding this comment.
I'm not sure I understand the point of this entity, or how we can own a definition that's not coming from our agents.
There was a problem hiding this comment.
This Uninstrumented Entity is created when a Candidate Relationship can not be resolved as per KUBERNETESCLUSTER candidate definition.
Our proposal is assigning the Uninstrumented Entities to the owners of their "regular Entity" counterpart.
In this case, your team owns INFRA-KUBERNETESCLUSTER
|
👋 This PR has seen no activity in over 3 days and is still awaiting approval from: @newrelic/BEYOND, @newrelic/OHAI, @newrelic/K8S-AGENTS Please review or provide an update. |
|
👋 This PR has seen no activity in over 3 days and is still awaiting approval from: @newrelic/BEYOND, @newrelic/OHAI Please review or provide an update. |
1 similar comment
|
👋 This PR has seen no activity in over 3 days and is still awaiting approval from: @newrelic/BEYOND, @newrelic/OHAI Please review or provide an update. |
7 participants
Relevant information
Updates entity ownership for UNINSTRUMENTED definitions that had no owner assigned. It matches the owner on the regular entity types.
Checklist
identifierwill be unique and valid.