Skip to content

[nr-k8s-otel-collector] make collector observability resource attributes configurable #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
achang209 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[nr-k8s-otel-collector] make collector observability resource attributes configurable #2133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9eec0e4
update to seconds to match what is already defined in the configmaps
alex-chang-tango Feb 26, 2026
130981c
add resource attributes
alex-chang-tango Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/nr-k8s-otel-collector/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.10.8
version: 0.10.9

@dbudziwojskiNR dbudziwojskiNR Jul 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to bump this version anymore, our CICD process will do so on release.



dependencies:
Expand Down
5 changes: 5 additions & 0 deletions charts/nr-k8s-otel-collector/templates/daemonset-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -827,6 +827,11 @@ data:
endpoint: {{ include "nrKubernetesOtel.endpoint" . }}
headers:
api-key: ${env:NR_LICENSE_KEY}
resource:

@dbudziwojskiNR dbudziwojskiNR Jul 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we stamp the cluster name through a traditional processor in a pipeline instead? This leaves the door open to stamping other attributes from processors like resource_detection

k8s.cluster.name: {{ include "newrelic.common.cluster" . }}
{{- range $k, $v := .Values.collectorObservability.resource }}
{{ $k }}: {{ $v }}
{{- end }}
{{- end }}
pipelines:
{{- include "nrKubernetesOtel.daemonset.configMap.extraConfig.pipelines" . | nindent 8 }}
Expand Down
5 changes: 5 additions & 0 deletions charts/nr-k8s-otel-collector/templates/deployment-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,6 +804,11 @@ data:
endpoint: {{ include "nrKubernetesOtel.endpoint" . }}
headers:
api-key: ${env:NR_LICENSE_KEY}
resource:

@dbudziwojskiNR dbudziwojskiNR Jul 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here.

k8s.cluster.name: {{ include "newrelic.common.cluster" . }}
{{- range $k, $v := .Values.collectorObservability.resource }}
{{ $k }}: {{ $v }}
{{- end }}
{{- end }}
pipelines:
{{- include "nrKubernetesOtel.deployment.configMap.extraConfig.pipelines" . | nindent 8 }}
Expand Down
15 changes: 12 additions & 3 deletions charts/nr-k8s-otel-collector/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,9 +332,18 @@ collectorObservability:
# -- (bool) Specifies whether the collector reports its own metrics
# @default -- `false`
enabled: false
# -- Specifies the interval at which the collector reports its metrics (in milliseconds)
# @default -- `60000`
scrapeIntervalMs: 60000
# -- Specifies the interval at which the collector reports its metrics (in seconds)
# @default -- `60`
scrapeIntervalSeconds: 60

@dbudziwojskiNR dbudziwojskiNR Jul 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value should probably remain as scrapeIntervalMs, and instead we should fix this on the deployment and daemonset since periodic.interval accepts ms, not seconds. Alternatively, we could try and normalize this to seconds. Open to ideas.

# -- Additional resource attributes to attach to its internal metrics.
# k8s.cluster.name is automatically populated from the cluster value.
# Useful for adding attributes such as env to distinguish between environments
# in multi-cluster deployments.
# Example:
# resource:
# env: production
# @default -- `{}`
resource: {}

# -- (bool) Send only the [metrics required](https://github.com/newrelic/helm-charts/tree/master/charts/nr-k8s-otel-collector/docs/metrics-lowDataMode.md) to light up the NR kubernetes UI
# @default -- `true`
Expand Down
Loading