feat(appName): add appName via annotation#517
Open
paologallinaharbur wants to merge 2 commits intonewrelic:mainfrom
Open
feat(appName): add appName via annotation#517paologallinaharbur wants to merge 2 commits intonewrelic:mainfrom
paologallinaharbur wants to merge 2 commits intonewrelic:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #517 +/- ##
==========================================
+ Coverage 68.74% 68.94% +0.20%
==========================================
Files 53 53
Lines 3513 3520 +7
==========================================
+ Hits 2415 2427 +12
+ Misses 863 861 -2
+ Partials 235 232 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c161c03 to
99ba88f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduce a new small feature.
Whenever the annotation
newrelic.com/app-nameis found in an instrumentation CR, all the container instrumented thanks to that instrumentation CR will leverage the value of such annotation to populate NEW_RELIC_APP_NAME.If the annotation is not present or if the user was specifying the APP_NAME via environment variable the behaviour is not changed