Skip to content

feat(appName): add appName via annotation#517

Open
paologallinaharbur wants to merge 2 commits intonewrelic:mainfrom
paologallinaharbur:feat/appm_name
Open

feat(appName): add appName via annotation#517
paologallinaharbur wants to merge 2 commits intonewrelic:mainfrom
paologallinaharbur:feat/appm_name

Conversation

@paologallinaharbur
Copy link
Copy Markdown
Member

This PR introduce a new small feature.

Whenever the annotation newrelic.com/app-name is found in an instrumentation CR, all the container instrumented thanks to that instrumentation CR will leverage the value of such annotation to populate NEW_RELIC_APP_NAME.

If the annotation is not present or if the user was specifying the APP_NAME via environment variable the behaviour is not changed

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.94%. Comparing base (aeb670c) to head (986bc01).

Files with missing lines Patch % Lines
internal/apm/dotnet.go 0.00% 0 Missing and 1 partial ⚠️
internal/apm/dotnetwindows.go 0.00% 0 Missing and 1 partial ⚠️
internal/apm/java.go 0.00% 0 Missing and 1 partial ⚠️
internal/apm/nodejs.go 0.00% 0 Missing and 1 partial ⚠️
internal/apm/php.go 0.00% 0 Missing and 1 partial ⚠️
internal/apm/python.go 0.00% 0 Missing and 1 partial ⚠️
internal/apm/ruby.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
+ Coverage   68.74%   68.94%   +0.20%     
==========================================
  Files          53       53              
  Lines        3513     3520       +7     
==========================================
+ Hits         2415     2427      +12     
+ Misses        863      861       -2     
+ Partials      235      232       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant