feat: Add more inspection events#1494
Merged
Merged
Conversation
Supportability Metric Usage Changes:No matching changes found Supportability Metrics .md File Changes:supportability_metrics.md was changed? New supportability metrics require changes to supportability_metrics.md, as well as a new PR to Angler. Please ensure an Angler PR is created and linked to this PR. |
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
f75005f to
40f86a8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1494 +/- ##
==========================================
+ Coverage 87.61% 87.64% +0.02%
==========================================
Files 197 197
Lines 7761 7778 +17
Branches 1563 1565 +2
==========================================
+ Hits 6800 6817 +17
- Misses 826 827 +1
+ Partials 135 134 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
863fb4f to
b17c046
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new inspection events to the agent. These events include the drain event, window lifecycle events such as navigate, load, DOMContentLoaded, and the session event which emits on changes to the agent's session state.
Overview
Adds new inspection events to the agent. These are new events not originally outlined in the CDD. The 'origin' event mentioned in the JIRA ticket is excluded due to too much code effort and not enough of a use case to have it.
drain event: Emits when the agent drains for a particular feature
window lifecycle events:
session event: Emits when the agent's session state changes
Related Issue(s)
JIRA: https://new-relic.atlassian.net/browse/NR-377594
Follow-up ticket: https://new-relic.atlassian.net/browse/NR-375666
Testing
The inspection-events tests were expanded. Open the
inspection-events.htmlin the test server to test locally.Make sure tests pass for this PR.