feat: Improve agent startup#1760
Conversation
Some tests were failing when retries is set to 0. Fixed up and removed the retries as they don't seem needed for unit/integration tests (?)
- If entitlement is unconfirmed, avoid locking session into OFF mode - Use null instead of OFF as the default value (need null to write into LS)
Supportability Metric Usage Changes:No matching changes found Supportability Metrics .md File Changes:supportability_metrics.md was changed? New supportability metrics require changes to supportability_metrics.md, as well as a new PR to Angler. Please ensure an Angler PR is created and linked to this PR. |
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1760 +/- ##
==========================================
+ Coverage 89.54% 90.07% +0.53%
==========================================
Files 213 214 +1
Lines 7864 7852 -12
Branches 1657 1669 +12
==========================================
+ Hits 7042 7073 +31
+ Misses 743 709 -34
+ Partials 79 70 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
metal-messiah
left a comment
There was a problem hiding this comment.
Just some general WIP comments, looking good!
metal-messiah
left a comment
There was a problem hiding this comment.
This looks good and makes sense. I assume app metadata is unneeded for the cache, but just want to double check that above ⬆️ before merging.
- Don't wait for new RUM call if a cached response is present. - Added `app` to the cached response - Added a rough implementation of namespaced LS to flush out any tests that would break.
Co-authored-by: Chunwai Li <cli@newrelic.com>
ee1182c to
d774a7f
Compare
Provide better support for scenarios where agent startup can be interrupted before RUM call completes successfully and feature session modes are saved into local storage (where applicable).
Overview
In this PR,
Related Issue(s)
https://new-relic.atlassian.net/browse/NR-509779
Testing
Extended integration tests in affected parts of the agent.
Manually tested scenario to ensure RUM response is cached in the session.