fix: Calculate browser_stack_hash from truncated stack trace#1789
Merged
Conversation
Supportability Metric Usage Changes:No matching changes found Supportability Metrics .md File Changes:supportability_metrics.md was changed? New supportability metrics require changes to supportability_metrics.md, as well as a new PR to Angler. Please ensure an Angler PR is created and linked to this PR. |
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1789 +/- ##
==========================================
+ Coverage 89.45% 89.54% +0.08%
==========================================
Files 213 213
Lines 7864 7864
Branches 1657 1657
==========================================
+ Hits 7035 7042 +7
+ Misses 746 743 -3
+ Partials 83 79 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ptang-nr
reviewed
Jun 9, 2026
ellisong
force-pushed
the
NR-558128-stack-hash
branch
from
3b13c3d to
093e3b4
Compare
ellisong
changed the title
ellisong
changed the title
ptang-nr
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calculate the browser stack hash off of the truncated stack trace instead of the non-truncated stack trace. Before this change, first-occurrence harvests of JSE events can have a different browser stack hash from future harvests of the same stack trace if it was truncated. This will improve error grouping of JavaScriptError events.
Overview
Related Issue(s)
JIRA: https://new-relic.atlassian.net/browse/NR-558128
Testing
Make sure unit tests pass. We can add more testing related to truncation logic if it helps.